-
-
Notifications
You must be signed in to change notification settings - Fork 699
/
Copy pathSimplifyArraySearchRector.php
69 lines (67 loc) · 2.53 KB
/
SimplifyArraySearchRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
<?php
declare (strict_types=1);
namespace Rector\CodeQuality\Rector\Identical;
use PhpParser\Node;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\BinaryOp\Identical;
use PhpParser\Node\Expr\BinaryOp\NotIdentical;
use PhpParser\Node\Expr\BooleanNot;
use PhpParser\Node\Expr\FuncCall;
use Rector\NodeManipulator\BinaryOpManipulator;
use Rector\Php71\ValueObject\TwoNodeMatch;
use Rector\PhpParser\Node\Value\ValueResolver;
use Rector\Rector\AbstractRector;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
/**
* @see \Rector\Tests\CodeQuality\Rector\Identical\SimplifyArraySearchRector\SimplifyArraySearchRectorTest
*/
final class SimplifyArraySearchRector extends AbstractRector
{
/**
* @readonly
*/
private BinaryOpManipulator $binaryOpManipulator;
/**
* @readonly
*/
private ValueResolver $valueResolver;
public function __construct(BinaryOpManipulator $binaryOpManipulator, ValueResolver $valueResolver)
{
$this->binaryOpManipulator = $binaryOpManipulator;
$this->valueResolver = $valueResolver;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Simplify array_search to in_array', [new CodeSample('array_search("searching", $array) !== false;', 'in_array("searching", $array);'), new CodeSample('array_search("searching", $array, true) !== false;', 'in_array("searching", $array, true);')]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [Identical::class, NotIdentical::class];
}
/**
* @param Identical|NotIdentical $node
*/
public function refactor(Node $node) : ?Node
{
$twoNodeMatch = $this->binaryOpManipulator->matchFirstAndSecondConditionNode($node, function (Node $node) : bool {
if (!$node instanceof FuncCall) {
return \false;
}
return $this->nodeNameResolver->isName($node, 'array_search');
}, fn(Node $node): bool => $node instanceof Expr && $this->valueResolver->isFalse($node));
if (!$twoNodeMatch instanceof TwoNodeMatch) {
return null;
}
/** @var FuncCall $funcCallExpr */
$funcCallExpr = $twoNodeMatch->getFirstExpr();
$inArrayFuncCall = $this->nodeFactory->createFuncCall('in_array', $funcCallExpr->args);
if ($node instanceof Identical) {
return new BooleanNot($inArrayFuncCall);
}
return $inArrayFuncCall;
}
}