-
-
Notifications
You must be signed in to change notification settings - Fork 688
/
ArgumentAdderRector.php
328 lines (324 loc) · 12.5 KB
/
ArgumentAdderRector.php
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
<?php
declare (strict_types=1);
namespace Rector\Arguments\Rector\ClassMethod;
use PhpParser\BuilderHelpers;
use PhpParser\Node;
use PhpParser\Node\Arg;
use PhpParser\Node\Expr;
use PhpParser\Node\Expr\MethodCall;
use PhpParser\Node\Expr\StaticCall;
use PhpParser\Node\Expr\Variable;
use PhpParser\Node\Name;
use PhpParser\Node\Param;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use PHPStan\Type\ObjectType;
use PHPStan\Type\Type;
use Rector\Arguments\NodeAnalyzer\ArgumentAddingScope;
use Rector\Arguments\NodeAnalyzer\ChangedArgumentsDetector;
use Rector\Arguments\ValueObject\ArgumentAdder;
use Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue;
use Rector\Contract\Rector\ConfigurableRectorInterface;
use Rector\Enum\ObjectReference;
use Rector\Exception\ShouldNotHappenException;
use Rector\PhpParser\AstResolver;
use Rector\PHPStanStaticTypeMapper\Enum\TypeKind;
use Rector\Rector\AbstractRector;
use Rector\StaticTypeMapper\StaticTypeMapper;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use RectorPrefix202501\Webmozart\Assert\Assert;
/**
* @see \Rector\Tests\Arguments\Rector\ClassMethod\ArgumentAdderRector\ArgumentAdderRectorTest
*/
final class ArgumentAdderRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @readonly
*/
private ArgumentAddingScope $argumentAddingScope;
/**
* @readonly
*/
private ChangedArgumentsDetector $changedArgumentsDetector;
/**
* @readonly
*/
private AstResolver $astResolver;
/**
* @readonly
*/
private StaticTypeMapper $staticTypeMapper;
/**
* @var ArgumentAdder[]|ArgumentAdderWithoutDefaultValue[]
*/
private array $addedArguments = [];
private bool $hasChanged = \false;
public function __construct(ArgumentAddingScope $argumentAddingScope, ChangedArgumentsDetector $changedArgumentsDetector, AstResolver $astResolver, StaticTypeMapper $staticTypeMapper)
{
$this->argumentAddingScope = $argumentAddingScope;
$this->changedArgumentsDetector = $changedArgumentsDetector;
$this->astResolver = $astResolver;
$this->staticTypeMapper = $staticTypeMapper;
}
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('This Rector adds new default arguments in calls of defined methods and class types.', [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
$someObject = new SomeExampleClass;
$someObject->someMethod();
class MyCustomClass extends SomeExampleClass
{
public function someMethod()
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
$someObject = new SomeExampleClass;
$someObject->someMethod(true);
class MyCustomClass extends SomeExampleClass
{
public function someMethod($value = true)
{
}
}
CODE_SAMPLE
, [new ArgumentAdder('SomeExampleClass', 'someMethod', 0, 'someArgument', \true, new ObjectType('SomeType'))])]);
}
/**
* @return array<class-string<Node>>
*/
public function getNodeTypes() : array
{
return [MethodCall::class, StaticCall::class, Class_::class];
}
/**
* @param MethodCall|StaticCall|Class_ $node
* @return \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall|\PhpParser\Node\Stmt\Class_|null
*/
public function refactor(Node $node)
{
$this->hasChanged = \false;
if ($node instanceof MethodCall || $node instanceof StaticCall) {
$this->refactorCall($node);
} else {
foreach ($node->getMethods() as $classMethod) {
$this->refactorClassMethod($node, $classMethod);
}
}
if ($this->hasChanged) {
return $node;
}
return null;
}
/**
* @param mixed[] $configuration
*/
public function configure(array $configuration) : void
{
Assert::allIsAnyOf($configuration, [ArgumentAdder::class, ArgumentAdderWithoutDefaultValue::class]);
$this->addedArguments = $configuration;
}
/**
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $call
*/
private function isObjectTypeMatch($call, ObjectType $objectType) : bool
{
if ($call instanceof MethodCall) {
return $this->isObjectType($call->var, $objectType);
}
return $this->isObjectType($call->class, $objectType);
}
/**
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function processPositionWithDefaultValues($node, $argumentAdder) : void
{
if ($this->shouldSkipParameter($node, $argumentAdder)) {
return;
}
$argumentType = $argumentAdder->getArgumentType();
$position = $argumentAdder->getPosition();
if ($node instanceof ClassMethod) {
$this->addClassMethodParam($node, $argumentAdder, $argumentType, $position);
return;
}
if ($node instanceof StaticCall) {
$this->processStaticCall($node, $position, $argumentAdder);
return;
}
$this->processMethodCall($node, $argumentAdder, $position);
}
/**
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function processMethodCall(MethodCall $methodCall, $argumentAdder, int $position) : void
{
if ($argumentAdder instanceof ArgumentAdderWithoutDefaultValue) {
return;
}
$defaultValue = $argumentAdder->getArgumentDefaultValue();
$arg = new Arg(BuilderHelpers::normalizeValue($defaultValue));
if (isset($methodCall->args[$position])) {
return;
}
$this->fillGapBetweenWithDefaultValue($methodCall, $position);
$methodCall->args[$position] = $arg;
$this->hasChanged = \true;
}
/**
* @param \PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
*/
private function fillGapBetweenWithDefaultValue($node, int $position) : void
{
$lastPosition = \count($node->getArgs()) - 1;
if ($position <= $lastPosition) {
return;
}
if ($position - $lastPosition === 1) {
return;
}
$classMethod = $this->astResolver->resolveClassMethodFromCall($node);
if (!$classMethod instanceof ClassMethod) {
return;
}
for ($index = $lastPosition + 1; $index < $position; ++$index) {
$param = $classMethod->params[$index];
if (!$param->default instanceof Expr) {
throw new ShouldNotHappenException('Previous position does not have default value');
}
$node->args[$index] = new Arg($this->nodeFactory->createReprintedNode($param->default));
}
}
/**
* @param \PhpParser\Node\Stmt\ClassMethod|\PhpParser\Node\Expr\MethodCall|\PhpParser\Node\Expr\StaticCall $node
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function shouldSkipParameter($node, $argumentAdder) : bool
{
$position = $argumentAdder->getPosition();
$argumentName = $argumentAdder->getArgumentName();
if ($argumentName === null) {
return \true;
}
if ($node instanceof ClassMethod) {
// already added?
if (!isset($node->params[$position])) {
return \false;
}
$param = $node->params[$position];
// argument added and name has been changed
if (!$this->isName($param, $argumentName)) {
return \true;
}
// argument added and default has been changed
if ($this->isDefaultValueChanged($argumentAdder, $node, $position)) {
return \true;
}
// argument added and type has been changed
return $this->changedArgumentsDetector->isTypeChanged($param, $argumentAdder->getArgumentType());
}
if (isset($node->args[$position])) {
return \true;
}
// Check if default value is the same
$classMethod = $this->astResolver->resolveClassMethodFromCall($node);
if (!$classMethod instanceof ClassMethod) {
// is correct scope?
return !$this->argumentAddingScope->isInCorrectScope($node, $argumentAdder);
}
if (!isset($classMethod->params[$position])) {
// is correct scope?
return !$this->argumentAddingScope->isInCorrectScope($node, $argumentAdder);
}
if ($this->isDefaultValueChanged($argumentAdder, $classMethod, $position)) {
// is correct scope?
return !$this->argumentAddingScope->isInCorrectScope($node, $argumentAdder);
}
return \true;
}
/**
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function isDefaultValueChanged($argumentAdder, ClassMethod $classMethod, int $position) : bool
{
return $argumentAdder instanceof ArgumentAdder && $this->changedArgumentsDetector->isDefaultValueChanged($classMethod->params[$position], $argumentAdder->getArgumentDefaultValue());
}
/**
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function addClassMethodParam(ClassMethod $classMethod, $argumentAdder, ?Type $type, int $position) : void
{
$argumentName = $argumentAdder->getArgumentName();
if ($argumentName === null) {
throw new ShouldNotHappenException();
}
if ($argumentAdder instanceof ArgumentAdder) {
$param = new Param(new Variable($argumentName), BuilderHelpers::normalizeValue($argumentAdder->getArgumentDefaultValue()));
} else {
$param = new Param(new Variable($argumentName));
}
if ($type instanceof Type) {
$param->type = $this->staticTypeMapper->mapPHPStanTypeToPhpParserNode($type, TypeKind::PARAM);
}
$classMethod->params[$position] = $param;
$this->hasChanged = \true;
}
/**
* @param \Rector\Arguments\ValueObject\ArgumentAdder|\Rector\Arguments\ValueObject\ArgumentAdderWithoutDefaultValue $argumentAdder
*/
private function processStaticCall(StaticCall $staticCall, int $position, $argumentAdder) : void
{
if ($argumentAdder instanceof ArgumentAdderWithoutDefaultValue) {
return;
}
$argumentName = $argumentAdder->getArgumentName();
if ($argumentName === null) {
throw new ShouldNotHappenException();
}
if (!$staticCall->class instanceof Name) {
return;
}
if (!$this->isName($staticCall->class, ObjectReference::PARENT)) {
return;
}
$this->fillGapBetweenWithDefaultValue($staticCall, $position);
$staticCall->args[$position] = new Arg(new Variable($argumentName));
$this->hasChanged = \true;
}
/**
* @param \PhpParser\Node\Expr\StaticCall|\PhpParser\Node\Expr\MethodCall $call
*/
private function refactorCall($call) : void
{
if ($call->isFirstClassCallable()) {
return;
}
$callName = $this->getName($call->name);
if ($callName === null) {
return;
}
foreach ($this->addedArguments as $addedArgument) {
if (!$this->nodeNameResolver->isStringName($callName, $addedArgument->getMethod())) {
continue;
}
if (!$this->isObjectTypeMatch($call, $addedArgument->getObjectType())) {
continue;
}
$this->processPositionWithDefaultValues($call, $addedArgument);
}
}
private function refactorClassMethod(Class_ $class, ClassMethod $classMethod) : void
{
foreach ($this->addedArguments as $addedArgument) {
if (!$this->isName($classMethod, $addedArgument->getMethod())) {
continue;
}
if (!$this->isObjectType($class, $addedArgument->getObjectType())) {
continue;
}
$this->processPositionWithDefaultValues($classMethod, $addedArgument);
}
}
}