-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support React 19 #4558
Comments
React 19 will be added to peerDependencies when recharts supports it. Edit: Current alpha https://www.npmjs.com/package/recharts/v/2.13.0-alpha.4 |
Going to edit the title if you don't mind to just "Support React 19", and use this to track support in 2.x |
Alpha release - https://www.npmjs.com/package/recharts/v/2.13.0-alpha.0 use this to determine what is breaking/what isn't. I just don't have bandwidth to fix it myself Things that I know are broken: Bar |
https://www.npmjs.com/package/recharts/v/2.13.0-alpha.2 Please test this one as well on all React versions 16.8-19 to see if anyone runs into issues. Thanks! 🚀 |
In order to use React 19 one must override the
|
appreciate your work @ckifer |
My only issue remaining is |
@juliusmarminge Not sure why the types broke, are there React 19 types released? I can't seem to reproduce. But might need to add explicit Also noticed that @rauchg - I think probably another defaultProps issue that hasn't been caught yet. Will take another look Edit: for Legend for now you can just add the defaultProps back yourself (not sure if you can do this in Tremor)
|
I've also noticed a particular difference only when updating from I have an AreaChart (without set height/width) wrapped with ResponsiveContainer:
After updating though, the same exact code does not render the graph in any way I have tried with both set/dynamic dimensions on the AreaChart component, ResponsiveContainer or the other wrapping html tags (following the examples on the docs website) but the chart either doesn't render at all or loses all the responsive features it had before. Is this also true on your end? |
@emanuele-moricci this sounds like your version of react-is hasn't been overridden #4558 (comment) Try to npm ls react-is and see if it gives you multiple versions. |
And you'd be right! For future reference: After that, I cancelled the |
You definitely need to force
|
https://www.npmjs.com/package/recharts/v/2.13.0-alpha.3 Alpha-3 should fix the Legend issues mentioned above. Please continue to report other issues as you run into them, thanks! |
Thanks @tobiaslins will look into it |
@tobiaslins I can reproduce here https://codesandbox.io/p/sandbox/stacked-bar-chart-7fwfgj |
recharts/src/util/ChartUtils.ts Line 1064 in fad4d30
This is why stacks fail - we expect an axisId to be present but it isn't getting defaulted because of the way defaulProps are read. This one doesn't seem as reasonable to refactor as the other ones so for now specifying axisIds on you graphical items and axes should fix it. Will work on a fix in the meantime |
New alpha version released https://www.npmjs.com/package/recharts/v/2.13.0-alpha.5 |
Can I use recharts bar chart component in my NextJS.14 app? |
Yes |
This PR finally fixes all Mantine extensions and components used in the Mantine example and should resolve #20. Mantine Charts are working now using the alpha version of Recharts to be compatible with React 19 tracked in recharts/recharts#4558. Removes now unnecessary Vite `resolve.alias` workarounds. Also included are some UI updates on the example: using the original Mantine logo, fixing some typos and changing how CSS files are imported for each page instead of all CSS are imported in the layout.
For folks using bun and still running into issues:
|
Seems like it's fixed for the others yet I'm still having this issue. Relevant versions from my package.json: "dependencies": {
"next": "15.0.1",
"react": "19.0.0-rc-69d4b800-20241021",
"react-dom": "19.0.0-rc-69d4b800-20241021",
"recharts": "^2.13.0",
},
"devDependencies": {
"@types/react": "npm:[email protected]",
"@types/react-dom": "npm:[email protected]",
},
"overrides": {
"@types/react": "npm:[email protected]",
"@types/react-dom": "npm:[email protected]"
} |
@GetPsyched Your overrides are not correct. Override your "react-is" version to match your react version. |
Thanks for the extremely quick response! And it worked like a charm! Thanks. |
Do you want to request a feature or report a bug?
Bug
What is the current behavior?
Charts do not render when using React 19, or when using NextJS 14.3 (which uses React 19).
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via codesandbox or similar (template: https://codesandbox.io/p/sandbox/simple-line-chart-v25dl4).
Install react@rc or react@beta
Observe charts do not render
https://github.com/justinh00k/recharts-react19-repro
What is the expected behavior?
Charts render
Which versions of Recharts, and which browser / OS are affected by this issue? Did this work in previous versions of Recharts?
2.12.7 / No
The text was updated successfully, but these errors were encountered: