This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Adds tag filter support to resource EC2VPCEndpointServiceConfiguration #1175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we have done
We have a teardown use-case that needs to step over a particular EC2VPCEndpointServiceConfiguration that has the tag allow_delete set to false:
So we have added this configuration to the resource.
References
Evidence of work
Running the command dist/aws-nuke --config nuke-config.yml --quiet --target EC2VPCEndpointServiceConfiguration with the filter commented out from our config gives us:
With the filter present in our config we get:
This matches our expectations
Risks
I've not worked on this repo before and I'm not a regular Go-bot so my Go code might be suboptimal