Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Baseline account to automatically create filters #292

Closed
carter3d opened this issue Nov 9, 2018 · 5 comments
Closed

Baseline account to automatically create filters #292

carter3d opened this issue Nov 9, 2018 · 5 comments
Labels
kind/enhancement New core feature or improvement of existing ones. status/needs-proposal It is not clear how to fix this problem and it needs further discussion.

Comments

@carter3d
Copy link

carter3d commented Nov 9, 2018

I would like to be able to run a baseline that captured all currently configured services and defaults (like VPCs, subnets, etc) and output the results into a configuration file where each discovered resource would be filtered. Then, after some amount of use in the account (demos, training, experiments), the baseline config file would be used when running AWS Nuke to return the account to the starting state.

@svenwltr
Copy link
Member

This is an interesting idea. The only issue would be to clearly identify these resources. We could just use properties, but they are not implemented on every resource, yet. Also this might cause problems, if some resource generates dynamic properties (eg IP addresses). I currently do not have an idea how to solve this.

/cc @rebuy-de/prp-aws-nuke

@svenwltr svenwltr added kind/enhancement New core feature or improvement of existing ones. status/needs-proposal It is not clear how to fix this problem and it needs further discussion. labels Nov 12, 2018
@bjoernhaeuser
Copy link
Member

I like the idea. I could imagine to extend the current interface and change every resource to list the current one in a compatible format. In the end every resource has a ARN, and we could simply filter on them.

@svenwltr
Copy link
Member

In the end every resource has a ARN, and we could simply filter on them.

No, not every resource in terms of aws-nuke. There are some like IAMRolePolicyAttachment that are not really existent on AWS. The most of these resource are probably identifiable by using the two ARNs of the resource which it connects, but there are funny things like WAFRegionalByteMatchSetIP, where you need four values. This means we have to take a look at every resource itself and decide how to identify it.

@dooreelko
Copy link

A PR implementing this has been submitted #507
Let's give it some traction :)

@ekristen
Copy link
Contributor

ekristen commented Oct 1, 2024

I like this idea, I'm closing the issue, but haven't closed the PR. I'm looking at implemention possibilities over on the fork. I will comment on the PR as to what I decide to do.


Please see the copy of the notice from the README about the deprecation of this project. Sven was kind enough to grant me access to help triage and close issues and pull requests that have already been addressed in the actively maintained fork. Some additional information is located in the welcome issue for more information.

Caution

This repository for aws-nuke is no longer being actively maintained. We recommend users to switch to the actively maintained fork of this project at ekristen/aws-nuke.
We appreciate all the support and contributions we've received throughout the life of this project. We believe that the fork will continue to provide the functionality and support that you have come to expect from aws-nuke.
Please note that this deprecation means we will not be addressing issues, accepting pull requests, or making future releases from this repository.
Thank you for your understanding and support.

@ekristen ekristen closed this as completed Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New core feature or improvement of existing ones. status/needs-proposal It is not clear how to fix this problem and it needs further discussion.
Projects
None yet
Development

No branches or pull requests

5 participants