docs(openapi): amend response description for file deletion (#573) #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #573 +/- ##
=======================================
Coverage 73.41% 73.41%
=======================================
Files 15 15
Lines 1369 1369
=======================================
Hits 1005 1005
Misses 364 364
|
tiborsimko
reviewed
Apr 15, 2024
docs/openapi.json
Outdated
| @@ -1453,7 +1453,7 @@ | |||
| ], | |||
| "responses": { | |||
| "200": { | |||
| "description": "Requests succeeded. The file has been downloaded.", | |||
| "description": "Requests succeeded. Details about deleted files and failed deletions are returned.", | |||
There was a problem hiding this comment.
Isn't it rather "Request succeeded" in singular? (as in other REANA components)
tiborsimko
force-pushed
the
fix-typo-response-delete-file
branch
from
cec186c
to
81a5501
Compare
tiborsimko
pushed a commit
to giuseppe-steduto/reana-workflow-controller
that referenced
this pull request
Apr 15, 2024
tiborsimko
force-pushed
the
fix-typo-response-delete-file
branch
from
81a5501
to
1d027ff
Compare
tiborsimko
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.