Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app: investigate factory pattern usage #427

Open
audrium opened this issue Dec 7, 2021 · 0 comments
Open

app: investigate factory pattern usage #427

audrium opened this issue Dec 7, 2021 · 0 comments

Comments

@audrium
Copy link
Member

audrium commented Dec 7, 2021

It seems that factory.py and create_app() are only being used in reana-admin and scheduler (defined here). Needs a deeper investigation, but if that's the case there is no point in registering the blueprints there. Looks like invenio-base is taking care for starting up the application. To reproduce try to:
- comment/remove factory.py and app.py
- reana-dev docker-build -c . -b DEBUG=1
- reana-dev kind-load-docker-image -c .
- kill the old pod and inspect the new one - works as expected
- it does not work while redeploying the cluster because it can't start flask reana-admin create-admin-user

Stems from #417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant