feat(shutdown): stop all running jobs before stopping workflow (#423) #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonadoni
added a commit
to mdonadoni/reana-job-controller
that referenced
this pull request
Jan 23, 2024
…hub#423) Make sure that all the running jobs are stopped before stopping the run-batch pod, as otherwise they will continue running and they will not be cleaned up. Closes reanahub/reana-workflow-controller#546
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
d855d12
to
265bf1b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 47.78% 46.46% -1.32%
==========================================
Files 17 17
Lines 1149 1231 +82
==========================================
+ Hits 549 572 +23
- Misses 600 659 +59
|
giuseppe-steduto
approved these changes
Jan 26, 2024
There was a problem hiding this comment.
Works well and looks good to me! I personally don't have any special comments :)
I was not sure about the shutdown scope for the commit message, but it's more or less user-facing, it describes the affected functionality of r-j-controller, and I cannot really think of a better alternative
Maybe |
mdonadoni
added a commit
to mdonadoni/reana-job-controller
that referenced
this pull request
Jan 30, 2024
mdonadoni
added a commit
to mdonadoni/reana-job-controller
that referenced
this pull request
Jan 30, 2024
mdonadoni
added a commit
to mdonadoni/reana-job-controller
that referenced
this pull request
Jan 30, 2024
mdonadoni
added a commit
to mdonadoni/reana-job-controller
that referenced
this pull request
Jan 30, 2024
…hub#423) Make sure that all the running jobs are stopped before stopping the run-batch pod, as otherwise they will continue running and they will not be cleaned up. Closes reanahub/reana-workflow-controller#546
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
265bf1b
to
99c097e
Compare
Up until now, reana-workflow-controller was updating the status of jobs in the database. The updates are now managed by reana-job-controller instead, as reana-workflow-controller should not be concerned by this.
…hub#423) Make sure that all the running jobs are stopped before stopping the run-batch pod, as otherwise they will continue running and they will not be cleaned up. Closes reanahub/reana-workflow-controller#546
mdonadoni
force-pushed
the
fix-runaway-pods
branch
from
99c097e
to
866675b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes reanahub/reana-workflow-controller#546