Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move creation of open api clients to reana-commons #6

Open
dinosk opened this issue May 3, 2018 · 2 comments
Open

Move creation of open api clients to reana-commons #6

dinosk opened this issue May 3, 2018 · 2 comments
Labels

Comments

@dinosk
Copy link
Member

dinosk commented May 3, 2018

We can centralize the creation of open api clients (from server, client by moving them to reana-commons)

Same thing could be done for the open api tests (like in job-controller, workflow-controller).
Note there are two tests for the openapi, one for validation of the schema, and one to verify that the schema is not outdated.

@dinosk dinosk added this to the Internal-Consolidation milestone May 3, 2018
@diegodelemos
Copy link
Member

Addressed by #47. Central validation of OpenAPI specs and central testing if the spec is outdated still to be done.

@diegodelemos
Copy link
Member

Addressed by #71, reanahub/reana-server#115, reanahub/reana-client#214, reanahub/reana-workflow-engine-cwl#76, reanahub/reana-workflow-engine-serial#55 and #71 during Live-Mode sprint.


What remains:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants