Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): move from reST to markdown (#441) #441

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

mdonadoni
Copy link
Member

No description provided.

mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Feb 6, 2024
Convert docs from reStructuredText to markdown so that the changelog
file is compatible with `release-please`.
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (20ae9ce) 36.35% compared to head (36ce4e0) 36.35%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #441   +/-   ##
=======================================
  Coverage   36.35%   36.35%           
=======================================
  Files          26       26           
  Lines        1576     1576           
=======================================
  Hits          573      573           
  Misses       1003     1003           

Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍 Left one cosmetic comment WRT "Markdown" case and one MANIFEST.in comment WRT unnecessary lines there.

docs/conf.py Outdated
source_suffix = ".rst"
source_suffix = [".rst", ".md"]

# Allow using ::: in markdown files
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetics: the canonical spelling is Markdown, both here and in the commit log header and body.

(Ditto in the commit log body we could use "Release Please" instead of release-please.)

MANIFEST.in Outdated
@@ -20,6 +20,7 @@ prune docs/_build
recursive-include docs *.png
recursive-include docs *.py
recursive-include docs *.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't have anymore *.rst files, we could remove the following two lines from MANIFEST.in:

include *.rst
recursive-include docs *.rst

mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Feb 7, 2024
Convert docs from reStructuredText to Markdown so that the changelog
file is compatible with Release Please.
mdonadoni added a commit to mdonadoni/reana-commons that referenced this pull request Feb 7, 2024
Convert docs from reStructuredText to Markdown so that the changelog
file is compatible with Release Please.
Convert docs from reStructuredText to Markdown so that the changelog
file is compatible with Release Please.
@tiborsimko tiborsimko merged commit 36ce4e0 into reanahub:master Feb 9, 2024
17 checks passed
@mdonadoni mdonadoni deleted the markdown-changelog branch February 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants