-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(docs): move from reST to markdown (#441) #441
Conversation
Convert docs from reStructuredText to markdown so that the changelog file is compatible with `release-please`.
d6e077a
to
721de3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍 Left one cosmetic comment WRT "Markdown" case and one MANIFEST.in
comment WRT unnecessary lines there.
docs/conf.py
Outdated
source_suffix = ".rst" | ||
source_suffix = [".rst", ".md"] | ||
|
||
# Allow using ::: in markdown files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetics: the canonical spelling is Markdown, both here and in the commit log header and body.
(Ditto in the commit log body we could use "Release Please" instead of release-please
.)
MANIFEST.in
Outdated
@@ -20,6 +20,7 @@ prune docs/_build | |||
recursive-include docs *.png | |||
recursive-include docs *.py | |||
recursive-include docs *.rst |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't have anymore *.rst
files, we could remove the following two lines from MANIFEST.in
:
include *.rst
recursive-include docs *.rst
Convert docs from reStructuredText to Markdown so that the changelog file is compatible with Release Please.
721de3c
to
a2a37c4
Compare
Convert docs from reStructuredText to Markdown so that the changelog file is compatible with Release Please.
a2a37c4
to
3bdfa46
Compare
Convert docs from reStructuredText to Markdown so that the changelog file is compatible with Release Please.
3bdfa46
to
36ce4e0
Compare
No description provided.