New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: implement list --shared argument #692

Merged

tiborsimko merged 5 commits into reanahub:master from DaanRosendal:feature/list-shared

Sep 4, 2024

Member

DaanRosendal commented Nov 21, 2023

Adds new --shared, --shared-by, and --shared-with arguments to the
list CLI command to display workflows along with their sharing
information.

Closes #687

DaanRosendal force-pushed the feature/list-shared branch 4 times, most recently from b85d149 to f0393b2 Compare

March 14, 2024 16:00

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-add command (reanahub#692)

dbb40c7

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-remove command (reanahub#692)

8ba3b74

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

974bf61

Adds a new command to the CLI to retrieve whom a workflow is shared with.

Closes reanahub#686

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

5c6e058

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal force-pushed the feature/list-shared branch from f0393b2 to 5c6e058 Compare

March 14, 2024 16:03

DaanRosendal mentioned this pull request

cli: implement share-add command #683

Closed

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-add command (reanahub#692)

bcfd46c

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-remove command (reanahub#692)

9439d44

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681

DaanRosendal force-pushed the feature/list-shared branch from 5c6e058 to 75eaae6 Compare

March 18, 2024 09:59

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

db3d480

Adds a new command to the CLI to retrieve whom a workflow is shared with.

Closes reanahub#686

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

75eaae6

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-add command (reanahub#692)

15d9e1d

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-remove command (reanahub#692)

9f3fa52

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681

DaanRosendal force-pushed the feature/list-shared branch from 75eaae6 to 44a7cc6 Compare

March 18, 2024 10:11

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

Adds a new command to the CLI to retrieve whom a workflow is shared with.

Closes reanahub#686

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

44a7cc6

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

b7851dc

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to
the `list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal force-pushed the feature/list-shared branch from 44a7cc6 to b7851dc Compare

March 18, 2024 10:14

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-add command (reanahub#692)

953a56d

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-remove command (reanahub#692)

2240d01

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

492e0cc

Adds a new command to the CLI to retrieve whom a workflow is shared with.

Closes reanahub#686

DaanRosendal force-pushed the feature/list-shared branch from b7851dc to 4d7e0ae Compare

March 18, 2024 10:17

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

4d7e0ae

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to
the `list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

d0d935d

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub#686

DaanRosendal added a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

a90b056

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to
the `list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

DaanRosendal force-pushed the feature/list-shared branch from 4d7e0ae to a90b056 Compare

March 18, 2024 10:22

mdonadoni pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement share-status command (reanahub#692)

5243e94

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub#686

mdonadoni pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(cli): implement list --shared argument (reanahub#692)

c25d1e4

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

mdonadoni added a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update sharing commands after rebase (reanahub#692)

0881afb

Member

mdonadoni commented Aug 29, 2024

Ready to be reviewed, squashed and merged. CI should pass after a release of r-commons

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(share-add): add workflow sharing command (reanahub#692)

7a7b49f

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(share-remove): add workflow unsharing command (reanahub#692)

7ad5963

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(share-status): add workflow sharing status command (reanahub#692)

efb4084

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub#686

tiborsimko force-pushed the feature/list-shared branch from 0881afb to c8ab75d Compare

September 4, 2024 17:57

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          feat(list): add share-related arguments (reanahub#692)

fc0a4f9

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update sharing commands after changes (reanahub#692)

c8ab75d

tiborsimko approved these changes

View reviewed changes

Member

tiborsimko left a comment

Works nicely 👍 with

- r-client #692
- r-client-go #153
- r-ui #375
- r-server #658
- r-workflow-controller #552
- r-commons #429
- r-db #216

Kept separate commits, rephrased commit log headlines, bumped pytest-reana dependency.

DaanRosendal added 4 commits

September 4, 2024 20:03


          feat(workflow): add share-add command (reanahub#692)

f7b53e7

Adds a new command to the CLI to share a workflow with a user.

Closes reanahub#680


          feat(workflow): add share-remove command (reanahub#692)

20caca3

Adds a new command to the CLI to unshare a workflow.

Closes reanahub#681


          feat(workflow): add share-status command (reanahub#692)

807ef40

Adds a new command to the CLI to retrieve whom a workflow is shared
with.

Closes reanahub#686


          feat(worfklow): enrich list command with share-related arguments (rea…

5e4d12b

…nahub#692)

Adds new `--shared`, `--shared-by`, and `--shared-with` arguments to the
`list` CLI command to display workflows along with their sharing
information.

Closes reanahub#687

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update workflow sharing commands after changes (reanahub#692)

90a7312

tiborsimko force-pushed the feature/list-shared branch from c8ab75d to 90a7312 Compare

September 4, 2024 18:03

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update workflow sharing commands after changes (reanahub#692)

c504bde

tiborsimko force-pushed the feature/list-shared branch from 90a7312 to c504bde Compare

September 4, 2024 18:20

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update workflow sharing commands after changes (reanahub#692)

5e22c3b

tiborsimko force-pushed the feature/list-shared branch from c504bde to 5e22c3b Compare

September 4, 2024 19:18

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update workflow sharing commands after changes (reanahub#692)

865299a

tiborsimko force-pushed the feature/list-shared branch from 5e22c3b to 865299a Compare

September 4, 2024 19:27

tiborsimko pushed a commit to DaanRosendal/reana-client that referenced this pull request


          fix(cli): update workflow sharing commands after changes (reanahub#692)

292827d

tiborsimko force-pushed the feature/list-shared branch from 865299a to 292827d Compare

September 4, 2024 19:44


          fix(cli): update workflow sharing commands after changes (reanahub#692)

5d0aca7

Co-authored-by: Tibor Šimko <[email protected]>

tiborsimko force-pushed the feature/list-shared branch from 292827d to 5d0aca7 Compare

September 4, 2024 21:15

Member

tiborsimko commented Sep 4, 2024

Kept separate commits, rephrased commit log headlines, bumped pytest-reana dependency.

Also had to add a weird multi-dependency dance in setup.py due to not-yet-releasable reana-commons package so that CI would pass, as well as fixed the formatting of two CLI command examples in the help output so that it would match documentation (that needed some indentation fixes).

tiborsimko merged commit 5d0aca7 into reanahub:master

23 checks passed

github-actions bot mentioned this pull request

chore(master): release 0.95.0 #713

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet