Skip to content

Commit

Permalink
Merge pull request #15 from avsm/errata-1
Browse files Browse the repository at this point in the history
Errata 1 for latest Core/Async
  • Loading branch information
yminsky-janestreet committed Apr 20, 2014
2 parents 942fe3c + da57631 commit 32ea926
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 11 deletions.
5 changes: 3 additions & 2 deletions INSTALL.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/sh

opam install --yes \
opam install -j 4 --yes \
core \
core_extended \
cryptokit \
Expand All @@ -16,7 +16,8 @@ opam install --yes \
cmdliner \
cow \
ocp-indent \
ctypes
ctypes \
ocp-index

echo You also need Pygments installed.
echo This is python-pygments in Debian
2 changes: 1 addition & 1 deletion code/async/search.ml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let get_definition_from_json json =
let get_definition word =
Cohttp_async.Client.get (query_uri word)
>>= fun (_, body) ->
Pipe.to_list body
Pipe.to_list (Cohttp_async.Body.to_pipe body)
>>| fun strings ->
(word, get_definition_from_json (String.concat strings))

Expand Down
2 changes: 1 addition & 1 deletion code/async/search_with_error_handling.ml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ let get_definition ~server word =
try_with (fun () ->
Cohttp_async.Client.get (query_uri ~server word)
>>= fun (_, body) ->
Pipe.to_list body
Pipe.to_list (Cohttp_async.Body.to_pipe body)
>>| fun strings ->
(word, get_definition_from_json (String.concat strings)))
>>| function
Expand Down
2 changes: 1 addition & 1 deletion code/async/search_with_timeout_no_leak.ml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ let get_definition ~server ~interrupt word =
try_with (fun () ->
Cohttp_async.Client.get ~interrupt (query_uri ~server word)
>>= fun (_, body) ->
Pipe.to_list body
Pipe.to_list (Cohttp_async.Body.to_pipe body)
>>| fun strings ->
(word, get_definition_from_json (String.concat strings)))
>>| function
Expand Down
2 changes: 1 addition & 1 deletion code/async/test.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
THIS IS ONLY A TEST.
This is only a test.
4 changes: 2 additions & 2 deletions code/ffi/datetime.ml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ let () = seal timeval
type timezone
let timezone : timezone structure typ = structure "timezone"

let gettimeofday = foreign "gettimeofday"
(ptr timeval @-> ptr timezone @-> returning_checking_errno int)
let gettimeofday = foreign "gettimeofday" ~check_errno:true
(ptr timeval @-> ptr timezone @-> returning int)

let time' () = time (from_voidp time_t null)

Expand Down
2 changes: 1 addition & 1 deletion code/gc/run_barrier_bench.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
corebuild -pkg core_bench barrier_bench.native
./barrier_bench.native -ascii name alloc
./barrier_bench.native -ascii alloc
2 changes: 1 addition & 1 deletion code/maps-and-hash-tables/run_map_vs_hash.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
corebuild -pkg core_bench map_vs_hash.native
./map_vs_hash.native -ascii -clear-columns name time speedup
./map_vs_hash.native -ascii -clear-columns time speedup
2 changes: 1 addition & 1 deletion code/maps-and-hash-tables/run_map_vs_hash2.sh
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
corebuild -pkg core_bench map_vs_hash2.native
./map_vs_hash2.native -ascii -clear-columns name time speedup
./map_vs_hash2.native -ascii -clear-columns time speedup

0 comments on commit 32ea926

Please sign in to comment.