Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notes are not always properly shown in the HTML #3544

Open
yminsky opened this issue Feb 14, 2022 · 2 comments · May be fixed by #3650
Open

Notes are not always properly shown in the HTML #3544

yminsky opened this issue Feb 14, 2022 · 2 comments · May be fixed by #3650

Comments

@yminsky
Copy link
Member

yminsky commented Feb 14, 2022

Looking at this section:

https://dev.realworldocaml.org/concurrent-programming.html#tail-calls-and-chains-of-deferreds

it should be set off in a comment box, but isn't. Not sure why. The same thing shows up in other places too, e.g., the guided tour.
@avsm
Copy link
Member

avsm commented Feb 14, 2022

I swear these boxes just turn randomly turn on and off irrespective of the fixes I make...

@emillon
Copy link
Contributor

emillon commented Feb 17, 2022

The generated HTML is:

<section data-type="note">
  <h5>...</h5>
  ...
</section>

While the CSS rules look like section div[data-type=note]. So there's probably something that changed in the structure of the HTML output. (switching to section[data-type=note] should work)

@JiaeK JiaeK linked a pull request Oct 31, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix notes in the HTML JiaeK/RWObook
3 participants
@avsm @emillon @yminsky