-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize performance of string interning #7703
Comments
➤ PM Bot commented: Jira ticket: RCORE-2125 |
➤ nicola-cab commented: [~[email protected]] it seems we are slower in several cases compared to master, even when we use string IDs. I think this is known, I am just leaving a comment in this Jira, since I believe we are down to implementing the trimming logic and reviewing the string interner.
StringInterner::load_leaf_if_needed ... which is again loading the entire state from scratch. I wonder if it is possible to avoid that somehow. Considering these limitations: We are still better than current master for sorting a lot of dups strings with that are very long. This should apply to find_first too, but in this case the impacting of locking should be less evident, since we should be taking a lock less often. |
Performance of string interning needs to be optimized. Specifically the current implementation needs to load too much state on initialization. Instead we need to build a fast searchable structure in the file. This is in line with the design doc.
The text was updated successfully, but these errors were encountered: