-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Sphinx<5 compatibility leftovers #1512
Conversation
Allows developer to run ``` tox -e py310-sphinx72-firefox ``` This will run the tests and open a Firefox after building the demo site showing the `demo/demo.html` page on it. Then, you can also run: ``` tox -e py310-sphinx61-firefox ``` and compare the visual differences. Idea copied from #1388 Closes #1388
I tested this visually as well with Sphinx 5, 6 and 7 and I didn't find any issue so far. |
Co-authored-by: Dmitry Shachnev <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here all seem reasonable, however I'd probably say we should plan out release structure a bit more. At very least, it makes sense to focus 2.0rc1 on just changing dependencies, not changing code yet. Then at least projects can upgrade dependencies and transitive dependencies without us changing anything major about their project output.
So for that, I'd probably say a 2.0rc1 with dependencies upgraded and a 2.1rc1 following with actual changes to our theme. In that case, we'd block this for a bit longer.
If we need any of these changes specifically for Sphinx 7 support, they can be broken away from some of the cleanup changes here. But this looks mostly like housekeeping.
@agjohnson I split the required changes to support Sphinx >= 7.2 into #1519 and merge that one. I also update this PR with the latest changes. Now, this PR is only and cleanup of the support for older (now) un-supported versions. |
With @humitos thoughts here? |
…/sphinx_rtd_theme into humitos/sphinx-compatibility
… humitos/sphinx-compatibility
Sounds good to me! I've updated the PR to resolve the conflicts. |
This PR is ready to re-review and merge. I kept the injection of |
writer-html5
CSS classcss_tag
for better compatibility with newer Sphinx versions.filename
attribute for CSS and JS files forpathto
#1503@agjohnson this PR is a good candidate to be included in
2.0rc2
👍🏼 . If you approve it, I can try to make a release myself.