Not able to build theme from current git

[pedro-w]

Problem

I wanted to build the theme from the current code.

Reproducible Project

I am following the instructions in https://sphinx-rtd-theme.readthedocs.io/en/latest/contributing.html#

Error Logs/Results

I see several deprecation warnings and also these errors

    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.eot' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 5:38-81
    
    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.eot?v=4.7.0' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 4:38-89
    
    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.svg?v=4.7.0' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 9:38-89
    
    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.ttf?v=4.7.0' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 8:38-89
    
    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.woff2?v=4.7.0' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 6:38-91
    
    ERROR in ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass)
    Module not found: Error: Can't resolve '../fonts/fontawesome-webfont.woff?v=4.7.0' in '/tmp/sphinx_rtd_theme/src/sass'
     @ ./src/sass/theme.sass (./node_modules/css-loader/dist/cjs.js!./node_modules/sass-loader/dist/cjs.js??ref--5-2!./src/sass/theme.sass) 7:38-90

A browser starts showing the page but without any stylesheet applied.

Expected

Should not get errors and should be able to view page with styling.

Environment Info

• Python Version: 3.7.3
• Sphinx Version: 2.2.0
• RTD Theme Version: checkout from git on 23-sep-19
• Firefox 60.9
• Debian 10.1

[eine]

Might this be fixed by #808 already?

[pedro-w]

Is it correct to say that #808 has been merged but not into master? I will check it out and give it a try. I feel confident it should be fixed if #830 has been applied.
[edit] no I see it has been applied to master now. I'll close this once I've confirmed it's OK.

[eine]

In case it is useful to you, I'm building master with docker run --rm -v /$(pwd)://src -w //src node sh -c 'npm install; npm run build'.

[pedro-w]

Tried it from master using the build instructions

pip install -e '.[dev]'
npm install
npm run dev

All worked fine. Thanks everyone for their help.