Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Move Main Features and Feature Flags to "Reference/Features" (Diátaxis) #9915

Merged
merged 5 commits into from
Jan 27, 2023
Merged

Docs: Move Main Features and Feature Flags to "Reference/Features" (Diátaxis) #9915

merged 5 commits into from
Jan 27, 2023

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jan 18, 2023 •
edited by github-actions bot
Loading

Refs: #9746

  • Relabels "Feature Flags" as Reference
  • Moves "Main Features" to Reference/Features as well (this item is suggested for deletion later, so this is mainly a change to help the new "Reference/Features" section be easier to observe, scope, and define)

📚 Documentation previews 📚

@benjaoming benjaoming added the Needed: documentation Documentation is required label Jan 18, 2023
@benjaoming benjaoming requested a review from a team as a code owner January 18, 2023 14:43
@benjaoming benjaoming mentioned this pull request Jan 18, 2023
Closed
38 tasks
@benjaoming
Copy link
Contributor Author

Oh, actually it should also be noted that "Feature Flags" are also going to be deprecated and ultimately removed, so I think it's fine to not spend too much time here.

ericholscher
ericholscher approved these changes Jan 19, 2023
View reviewed changes
docs/user/reference/features.rst Outdated Show resolved Hide resolved
benjaoming and others added 4 commits January 27, 2023 20:28
@benjaoming @ericholscher
Update docs/user/feature-flags.rst
dee137c 
Co-authored-by: Eric Holscher <[email protected]>
@benjaoming
Merge branch 'diataxis/main' of github.com:readthedocs/readthedocs.or…
68b8115 
…g into diataxis/relabel-feature-as-reference
@benjaoming
Merge branch 'diataxis/relabel-feature-as-reference' of github.com:be…
85dd2a4 
…njaoming/readthedocs.org into diataxis/relabel-feature-as-reference
@benjaoming
linting
85ab1a9
@benjaoming
Copy link
Contributor Author

All inputs addressed, merging 👍

@benjaoming benjaoming merged commit 24d1d97 into readthedocs:diataxis/main Jan 27, 2023
@benjaoming benjaoming deleted the diataxis/relabel-feature-as-reference branch January 27, 2023 21:43
@ericholscher ericholscher mentioned this pull request Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

Assignees

@benjaoming benjaoming

Labels
Needed: documentation Documentation is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @ericholscher