Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing list.extend line when appending conda dependencies #5986

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Missing list.extend line when appending conda dependencies #5986

merged 1 commit into from
Jul 25, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Jul 24, 2019

It seems that in the last minute refactor of #5956 I deleted an important line that adds our conda core dependencies to the environment.yml file.

Now we are only adding our pip core dependencies, which is half of the work needed.

@humitos humitos requested review from a team and ericholscher July 24, 2019 11:10
agjohnson
agjohnson approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good 👍

@agjohnson agjohnson merged commit 00b14ba into master Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the humitos/append-core-deps-conda branch July 25, 2019 19:00
@humitos humitos mentioned this pull request Jul 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson