Add Domain model to track project Domains #1575
Conversation
ericholscher
added
the
PR: work in progress
ericholscher
added
PR: ready for review
and removed
PR: work in progress
Conflicts: readthedocs/restapi/serializers.py readthedocs/restapi/urls.py readthedocs/restapi/views/model_views.py
ericholscher
added
PR: ready for review
and removed
PR: work in progress
|
|
||
| This should be replaced with signals instead of calling trigger_build | ||
| explicitly. | ||
| """ | ||
| ''' |
There was a problem hiding this comment.
This reverts some previous clean up to follow pep257. When we turn on pep257 with the next round of linting, triple single quotes will be invalid. Same goes for the rest of the single quote changes below.
| ac_top = $('.ui-autocomplete').css('top'); | ||
| $('.ui-autocomplete').css({'width': '233px', 'top': ac_top + 10 }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Is this in use? And is it supposed to be using the search autocomplete endpoint? A better place for javascript is outside templates if so.
|
Edits look good, +1 pending test return |
Add Domain model to track project Domains
|
What is the ETA for releasing this? I'm planning to use Cloudflare for my custom domain. |
|
We didn't get this deployed on thurs, so will be going out on monday or tues with some other changes. |
|
I see this got deployed, but it still doesn't work with Cloudflare: https://docs.openchain.org. I still get the error message. |
|
@Flavien this is already merged and your issue is separate from this feature, you should open a ticket with more details. |
The goal here is to make our usage of domains more explicit. This includes CNAME's, and our tracking or domain usage of people on our site.
The main fiddly bit here is that if users change their CNAME to point at another project they will have to go into the previous project's admin and delete the Domain, since the URL's are unique.
Major work
Migration Plan