Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: New Explanation sub-levels + high-level introduction as explanation (Diátaxis) #10071

Closed

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Feb 24, 2023

Reviewing, cc: @ericholscher

  • The main main main contribution here is to organize the explanation section and add a very important main introduction, "Choosing a dedicated documentation platform".

  • Currently, this will have a lot of text that can be shortened or clarified.

  • You might also want to add something, but please see the comments at the top of "Choosing a dedicated documentation platform"

  • A lot of intentions are left behind as reST comments.. they can be eliminated by simply choosing to "not do this" and delete the comment.

Supersedes https://github.com/readthedocs/readthedocs.org/pull/10063/files with the full context of a new Explanation section.

Some filenames are now so badly misleading that they should be changed.

  • integrations.rst => explanation/continuous-documentation.rst + redirect
  • choosing-a-site.rst => explanation/dedicated-platform.rst + redirect
  • Possibly, add a graphic for "Continuous Documentation" to replace the lengthy Webhook explanation just remove that explanation for now

📚 Documentation previews 📚

ericholscher and others added 5 commits February 22, 2023 15:21
I got motivated to write this,
but struggled to figure out what to say in a clear way..

Leaving this in a draft for another day.
@benjaoming benjaoming changed the title Docs: New explanation sub-levels and pages Docs: New explanation sub-levels and pages (Diátaxis) Feb 24, 2023
@benjaoming benjaoming added Improvement Minor improvement to code Needed: documentation Documentation is required labels Feb 24, 2023
@benjaoming
Copy link
Contributor Author

@ericholscher this is now ready for review, of course I have left unintentional mistakes and there are many things that can benefit from your direct inputs. Please feel free to push directly 💯 Also see my updated description at the top ⬆️

@benjaoming benjaoming marked this pull request as ready for review March 28, 2023 20:58
@benjaoming benjaoming requested a review from a team as a code owner March 28, 2023 20:58
@benjaoming benjaoming requested a review from ericholscher March 28, 2023 20:58
@benjaoming
Copy link
Contributor Author

Btw... since there's a lot of new content, maybe the best way to start reviewing it is to build it locally since the PR preview has a lot of disturbing "diff view" :)

@benjaoming benjaoming changed the title Docs: New explanation sub-levels and pages (Diátaxis) Docs: New Explanation sub-levels + high-level introduction as explanation (Diátaxis) Apr 12, 2023
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a great change, but I worry that we're confusing the value we're providing to the user in terms of explanation, and not actually documenting how things work at a technical level, which is something the old docs did well around integrations that seem to be lost.

docs/user/explanation/continuous-documentation.rst Outdated Show resolved Hide resolved
docs/user/index.rst Outdated Show resolved Hide resolved
ericholscher and others added 2 commits April 14, 2023 08:38
There's still a bunch more work here, it's a bit overwhelming to try and get all the examples to fit together,
and I'm running out of energy to do a whole refactor.
benjaoming added a commit to benjaoming/readthedocs.org that referenced this pull request Apr 18, 2023
@benjaoming benjaoming mentioned this pull request Apr 18, 2023
2 tasks
benjaoming added a commit that referenced this pull request Apr 19, 2023
* Adds "reproducible" to glossary

* Adds glossary entries from #10071

* Make "webhook" respect a-z

* Improve reproducible entry

* Simplify the definition so its easier to understand

* Move root URL so it's a-z

* Remove "profile page"

* Add "pinning" to glossary

* Apply suggestions from @stsewd and @humitos code review

Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Santos Gallegos <[email protected]>

* Update docs/user/glossary.rst

Co-authored-by: Manuel Kaufmann <[email protected]>

* Put defining sentence first

* Add some references to new glossary entries

* Put definition first

* Add more references to pinning

---------

Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Santos Gallegos <[email protected]>
@ericholscher
Copy link
Member

Going to close this, and pull the small changes into a future PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: documentation Documentation is required
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants