Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: build.jobs could have pre_upload and post_upload jobs #9139

Open
humitos opened this issue Apr 25, 2022 · 1 comment
Open

Build: build.jobs could have pre_upload and post_upload jobs #9139

humitos opened this issue Apr 25, 2022 · 1 comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Apr 25, 2022

I don't think this is immediately needed, but while writing #9138 I realized that using post_build may not be enough in some cases. If we call a webhook in the post_build that crawls some pages that we just built but the upload step takes a considerable amount of time, the crawler will fetch the older version of the page while expecting the newer one. So, I'm proposing adding pre_upload and post_upload to avoid this kind of case.

@humitos humitos added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Apr 25, 2022
@humitos
Copy link
Member Author

humitos commented Apr 25, 2022

I just realized that this is what our Webhook feature does, and we may not want to promote doing this via a post_upload job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant