Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fake broadcast operations against builder queues #6775

Closed
agjohnson opened this issue Mar 11, 2020 · 1 comment · Fixed by #7044
Closed

Remove fake broadcast operations against builder queues #6775

agjohnson opened this issue Mar 11, 2020 · 1 comment · Fixed by #7044
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@agjohnson
Copy link
Contributor

Currently, we're using a fake broadcast task to trigger removal of paths on all build servers. With the move to scaling groups, the webs will no longer be tracking the individual build servers, and so our broadcast method of looping over APP_BUILD_SERVERS will not work anymore.

It's not clear if we even need these operations anymore however. This would probably be the place to start, and if not, we can start stripping out code when we're close to single process builders.

Otherwise, we might need to look into proper broadcast on the build queues.

@agjohnson agjohnson added Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required labels Mar 11, 2020
@humitos
Copy link
Member

humitos commented Mar 11, 2020

We do not need this broadcast function anymore. IIRC, I removed them all in #6535 but I left it there because it was only needed for the builders to wipe versions. However, that won't be needed anymore if we are going to use "always clean" or if we used the shared cached environment via storage (#6763).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants