Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD wants me to set up webhooks on a now non-maintaining project #4684

Closed
Neui opened this issue Sep 30, 2018 · 9 comments
Closed

RTD wants me to set up webhooks on a now non-maintaining project #4684

Neui opened this issue Sep 30, 2018 · 9 comments
Labels
Status: stale Issue will be considered inactive soon Support Support question

Comments

@Neui
Copy link

Neui commented Sep 30, 2018

Details

I owned the wla-dx documentation project but not the github repository, so RTD couldn't set up integration for it (or I just didn't do it, can't really remember). The point is I get the "The project wla-dx doesn't have a valid webhook set up, commits won't trigger new builds for this project."-warning. Now since it isn't my project, I added the owner as a maintainer and he removed me as a maintainer. Now I can't access any of the admin stuff any more and it isn't listed as "my project".

Expected Result

Not getting the "The project wla-dx doesn't have a valid webhook set up, commits won't trigger new builds for this project"-warning any more.

Actual Result

I am still getting the warning. Following the "the project integrations"-link leads me to a "This page does not exist yet." with the URL being https://readthedocs.org/dashboard/wla-dx/integrations/ .

Screenshot of the "my projects" page, showing my only project wla-dx-neui and the warning

@stsewd
Copy link
Member

stsewd commented Oct 1, 2018

If you click the the project integrations link, does it disappear?

Also, this seems like a bug, we should show this message to owners only, if a user is removed we need to clean the messages.

@stsewd stsewd added Bug A bug Needed: replication Bug replication is required labels Oct 1, 2018
@stsewd
Copy link
Member

stsewd commented Oct 1, 2018

/cc @humitos I think you are more familiar whit this part of the code.

@Neui
Copy link
Author

Neui commented Oct 1, 2018

If you click the the project integrations link, does it disappear?

As the time I reported this, it didn't dissapear. I clicked on it multiple times. (One before writing the issue to see where it leads to me and multiple times to see what the message is for the issue)

However, I just opened RTD again and clicked on it and it then dissapeared. Did something changed? Note that I just did this on a Windows computer with Firefox where before I was using an Ubuntu computer (also with Firefox).

@stsewd
Copy link
Member

stsewd commented Oct 1, 2018

Nothing has changed, that is the default behavior.

@remram44
Copy link

I am seeing this message even with a GitLab incoming webhook set (and working).

@stsewd
Copy link
Member

stsewd commented Oct 16, 2018

@remram44 can you try to click on the link? It should disappear, but anyway I think the error should disappear when everything is ok.

@remram44
Copy link

It did! Weird, I am sure I had clicked on it before (or middle-clicked).

@humitos
Copy link
Member

humitos commented Nov 2, 2018

I introduced this bug in #4033 when I refactored how the webhook was added from a Celery task instead of the same request process and how all the notifications work when triggered from Celery and attached to the user.

@humitos humitos added Accepted Accepted issue on our roadmap and removed Needed: replication Bug replication is required labels Nov 2, 2018
@agjohnson agjohnson added Support Support question and removed Bug A bug Accepted Accepted issue on our roadmap labels Jan 30, 2019
@stale
Copy link

stale bot commented Mar 16, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Mar 16, 2019
@stale stale bot closed this as completed Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: stale Issue will be considered inactive soon Support Support question
Projects
None yet
Development

No branches or pull requests

5 participants