-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong badge status in README.rst file, but correct status in RTD documentation #4557
Comments
The problem is that github is caching the badge internally with a control-cache header with |
Thanks for the insightful comment. In that case, do you know if that is something that I can fix on my end? Or are Github/Microsoft the only ones with the ability to fix the caching-issue? |
Sadly there is nothing users can do here, hope the rtd team can find the setting to fix this in the Azure storage. |
That makes sense. In that case, I'll wait and hopefully it can be fixed. But thanks again! |
Just linking some prior art on this, #3323 |
As @stsewd suggested, the final URL ( I see two oddities here but hopefully we can resolve them quickly. Firstly, the code to handle redirecting to the badges uses an undocumented (as far as I can tell) method in the staticfiles app. This should probably just use
Secondly, it looks like the cache-control header on the underlying storage (which if it goes through |
This is almost certainly related. Thanks. |
Details
Expected Result
Build status badge on the README.rst in the root directory shows up as "Failed" (Displaying as red color). However, the builds are passing and I was able to see the correct
documentation.
Actual Result
Build status badge color is displaying as red on the README.rst file in the root directory, even when the builds have passed and the documentation was properly built. When I look at it on Github, it shows up as red. However, when I go to the documentation, it the "docs" badge is green as says "passing".
I tried rebuilding the documentation, rearranging links, but I haven't had success yet.
I have also tried to put the link on a "badge_test.md" file (in root directory) without success. I literally copied and pasted the badge link from RTD for markdown.
I wanted to know if anyone else has this issue, or if anyone has an idea of how to fix it.
The text was updated successfully, but these errors were encountered: