Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BuildConfig to not use hardcoded constants #4388

Closed
davidfischer opened this issue Jul 17, 2018 · 0 comments · Fixed by #4704
Closed

Refactor BuildConfig to not use hardcoded constants #4388

davidfischer opened this issue Jul 17, 2018 · 0 comments · Fixed by #4704
Assignees
@stsewd
Labels
Improvement Minor improvement to code
Milestone
Refactoring

Comments

@davidfischer
Copy link
Contributor

While reviewing #4379 it came to my attention that we are using some hardcoded constants for logic like the string empty for a path to a nonexistant file. This causes a lot of weird behavior in tests. Instead, we should simply check if these variables exist. They should use None instead of a nonexistent file.
@davidfischer davidfischer added this to the Refactoring milestone Jul 17, 2018
@stsewd stsewd added the Improvement Minor improvement to code label Jul 17, 2018
@stsewd stsewd mentioned this issue Jul 18, 2018
Closed
@stsewd stsewd self-assigned this Sep 28, 2018
@stsewd stsewd mentioned this issue Oct 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stsewd stsewd

Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
Refactoring
Development

Successfully merging a pull request may close this issue.

Remove hardcoded constant from config module stsewd/readthedocs.org
2 participants
@davidfischer @stsewd