Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework around skipping a build #4257

Closed
humitos opened this issue Jun 18, 2018 · 1 comment · Fixed by #4991
Closed

Rework around skipping a build #4257

humitos opened this issue Jun 18, 2018 · 1 comment · Fixed by #4991
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Jun 18, 2018

Currently, we have something like if project.skip: return None in prepare_build which is then handled at trigger_build helper. It's not a really good workflow and we probably want to raise an exception instead and manage it in a proper way.

https://github.com/rtfd/readthedocs.org/blob/14942e9c1322a320ec3ecd34fe6a797e975d3a6f/readthedocs/core/utils/__init__.py#L98-L104

Additionally, we were thinking on managing this from a signal or similar that could be extended from outside. As an example, in .com we will probably be using something like organization.disabled where we will want to skip those builds also.

Also, the error message shown in the project detail page should be extended to show different messages depending on the skip reason. Currently, it's fixed to resource usage.

Ref: #4255

@humitos humitos added the Improvement Minor improvement to code label Jun 18, 2018
@humitos humitos added this to the Build error reporting milestone Jun 18, 2018
@stsewd
Copy link
Member

stsewd commented Dec 12, 2018

Related #4991

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants