Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pseudo-notification for webhooks from project pages #4235

Closed
agjohnson opened this issue Jun 13, 2018 · 1 comment
Closed

Move pseudo-notification for webhooks from project pages #4235

agjohnson opened this issue Jun 13, 2018 · 1 comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone

Comments

@agjohnson
Copy link
Contributor

In unifying some of the patterns for notifications, we noticed that the pseudo-notification for a disconnected webhook stands out. A couple patterns for moving this would be:

  • An indicator to let users know that project is incorrectly configured
  • Email notification on the problem, if it persists?
  • When a webhook is not configured correctly, instead of notifications pointing to the connect services page, we should point users with a persistent notification that points to the integration page. The integration page would mention the underlying issue ("You need to connect a GitHub account") with a pointer to how to resolve the issue.

With this, the notification can be removed from the base project base template.

@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Jun 13, 2018
@agjohnson agjohnson added this to the 2.8 milestone Jun 13, 2018
@stsewd stsewd modified the milestones: 2.11, 3.4 Feb 28, 2019
@stsewd stsewd modified the milestones: 3.4, 3.5 Mar 27, 2019
@humitos
Copy link
Member

humitos commented Oct 31, 2023

I'm considered this type of notification. It won't be attached to particular users, but to the Project instance instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants