-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MkdcocsJson builder #4205
Comments
@stsewd Is this issue still open? is used here |
Yup, that's where it needs to be removed. Actually, I was waiting to see if there are some efforts from the mkdocs side to bring back the json output, but I didn't find anything https://github.com/mkdocs/mkdocs/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+json But, looks like we could have a workaroung to bring search for mkdocs #4588 (comment) From my side, I think we can remove that code and worry about the future implementation later. Not sure anyway. |
should I make a PR? |
I'd wait for another maintainer to confirm |
Unblocking this, the json builder isn't needed to support mkdocs server search #6937 |
This was done in #6937 |
Now we use mkdocs 1.7, the json command was removed here https://www.mkdocs.org/about/release-notes/#other-changes-and-additions-to-version-0170
Looks like we aren't using it since I have built some mkdocs projects with no errors (just the html build is reported anyway).
Looks like it is used in the search
readthedocs/search/utils.py
file.Here is the unused builder
https://github.com/rtfd/readthedocs.org/blob/b693d56b23f4492a96b55a194c7030f84fc084b7/readthedocs/doc_builder/backends/mkdocs.py#L262-L266
The text was updated successfully, but these errors were encountered: