You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it's useful data to have. We originally added it to have basic stats, and the ability to query projects that aren't hooked up to a valid git repo. So I think adding it is probably useful.
While debugging a different issue (https://github.com/readthedocs/readthedocs-corporate/issues/332) I found that
Project.has_valid_clone
is present in just 3 places in the whole codebase and it's not really used/useful.Besides, we making an extra API call (https://github.com/rtfd/readthedocs.org/blob/10b6d53cbcdb33d9241a885e730784ba13da35e8/readthedocs/projects/tasks.py#L404) to set this to
True
on each build triggered after the setup step is done but since it's not present in the serializer (https://github.com/rtfd/readthedocs.org/blob/10b6d53cbcdb33d9241a885e730784ba13da35e8/readthedocs/restapi/serializers.py#L47) we are always making that PUT request which in fact it doesn't update anything because that value is lost.I did a quick query in production and there is 0 project with a valid clone :)
So,
ProjectAdminSerializer
and make it happen (PR Addhas_valid_clone
andhas_valid_webhook
to ProjectAdminSerializer #4107)The text was updated successfully, but these errors were encountered: