Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default to None when the key doesn't exist in environment.json #3861

Closed
humitos opened this issue Mar 26, 2018 · 0 comments
Closed

Default to None when the key doesn't exist in environment.json #3861

humitos opened this issue Mar 26, 2018 · 0 comments
Assignees
@humitos
Labels
Bug A bug
Milestone
New build features

Comments

@humitos
Copy link
Member

humitos commented Mar 26, 2018

On #3793 we should handle different cases when calling is_obsolete:

  1. environment.json doesn't exist -> False
  2. the JSON doesn't contain a new key (use None) -> True
  3. fail at parsing the JSON for some reason -> True

Ref: #3793 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@humitos humitos

Labels
Bug A bug
Projects
None yet
Milestone
New build features
Development

No branches or pull requests
1 participant
@humitos