Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Submit" text on buttons to something more meaningful #3735

Closed
stsewd opened this issue Mar 5, 2018 · 5 comments
Closed

Change "Submit" text on buttons to something more meaningful #3735

stsewd opened this issue Mar 5, 2018 · 5 comments
Labels
Design Design or UX/UI related Improvement Minor improvement to code

Comments

@stsewd
Copy link
Member

stsewd commented Mar 5, 2018

All the forms contains a button Submit to send the form, but is not always is the best word (where Save or Add would make more sense).

Probably should be done after some other PRs related to the UI gets merged, so we avoid a lot of conflicts.
@RichardLitt RichardLitt added Design Design or UX/UI related Needed: design decision A core team decision is required labels Mar 5, 2018
@shubham76
Copy link
Contributor

Hey @stsewd! I would like to work on this. Which other PRs are yet to be merged so that we can avoid conflicts with this one?

@stsewd
Copy link
Member Author

stsewd commented Mar 7, 2018

@shubham76 I think #3572, #3548, #3445 are the PRs that you need to be aware while making changes. You can make an initial PR and if the changes crosses on some file, better wait to the others PRs are merged to continue on that file. Let me know if you need more help, also this was initial suggested by @davidfischer, so he can help you with the correct words on the buttons if you aren't 100% sure.

@shubham76
Copy link
Contributor

Okay. I'll start working on it!
Thanks!

@davidfischer
Copy link
Contributor

I'm thrilled with this!

@humitos humitos added Improvement Minor improvement to code and removed Needed: design decision A core team decision is required labels Mar 7, 2018
@shubham76 shubham76 mentioned this issue Mar 7, 2018
Merged
@stsewd
Copy link
Member Author

stsewd commented Mar 9, 2018

Fixed on #3749

@stsewd stsewd closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design Design or UX/UI related Improvement Minor improvement to code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@davidfischer @humitos @RichardLitt @stsewd @shubham76