Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build 828171 is failing #3714

Closed
sfdye opened this issue Mar 2, 2018 · 5 comments
Closed

Build 828171 is failing #3714

sfdye opened this issue Mar 2, 2018 · 5 comments
Labels
Needed: replication Bug replication is required Support Support question

Comments

@sfdye
Copy link

sfdye commented Mar 2, 2018

Details

Expected Result

Build success for stable for the latest tag release v1.37 on Github

A description of what you wanted to happen

Actual Result

Build failed due to wrong version

A description of what actually happened

The stable version is still pointing to an old commit which did not fix the build.

#3279 should fix it.

Background

We did a migration of the Github link from:
https://github.com/jacquev6/PyGithub to https://github.com/PyGithub/PyGithub

@sfdye sfdye changed the title Build #828171 is failing Build 828171 is failing Mar 2, 2018
@RichardLitt RichardLitt added the Support Support question label Mar 2, 2018
@humitos
Copy link
Member

humitos commented Mar 2, 2018

You have two different things happening here:

  1. The error reported by RTD is
  File "conf.py", line 324, in <module>
    assert method is None or (githubClass, method) in [("github.StatsPunchCard.StatsPunchCard", "get")], githubClass + "." + method + " has no :calls: section"
AssertionError: github.PullRequestReviewerRequest.PullRequestReviewerRequest.__repr__ has no :calls: section

Which is related to your own project, not RTD.

  1. v1.37 is not being selected as stable version automatically. I'd say that this is not related to Provides a way to set the "stable" version manually #3279 because it should be automatically by RTD since it's the general rule and that issue linked is to skip that general rule for some other consideration. Anyway, in this case I think that you don't need to skip that rule, but you need that rule to work properly in your RTD project instead :)

@sfdye
Copy link
Author

sfdye commented Mar 3, 2018

@humitos Thank you very much for your response

  1. I am aware and this is already fixed in master, but as I said in the description the reason is because stable is pointing to the wrong sha, if it's pointing to master or 1.37 this failure should not appear.

  2. Okay, what is the solution then?

@stsewd
Copy link
Member

stsewd commented Mar 8, 2018

@sfdye I import your project on my local instance, the sha for stable match the one from v1.37

screenshot-2018-3-8 versions read the docs

This seems related to #3729. The user took an extreme step to solve the issue #3729 (comment)

@humitos
Copy link
Member

humitos commented Mar 9, 2018

I'm markng this a Needed: replication since it seems that we have a bug on our selection of the stable that it would be great to research a little more, but I'm not able to reproduce it.

@humitos humitos added the Needed: replication Bug replication is required label Mar 9, 2018
@sfdye
Copy link
Author

sfdye commented Mar 9, 2018

I finally get it working by deleting the project on rtd and importing again, thanks to advice from @stsewd . Don't think it's worth the effort to investigate and reproduce though, thus closing the issue. Re-open if anyone interested to dig in deeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: replication Bug replication is required Support Support question
Projects
None yet
Development

No branches or pull requests

4 participants