Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Maintainer is shown as a Owner #3694

Closed
humitos opened this issue Feb 27, 2018 · 7 comments
Closed

Adding a Maintainer is shown as a Owner #3694

humitos opened this issue Feb 27, 2018 · 7 comments
Labels
Improvement Minor improvement to code

Comments

@humitos
Copy link
Member

humitos commented Feb 27, 2018

  1. Go to your project's Admin page
  2. Go to Mainteiners
  3. Add a new mainteiner
  4. Go to your project's detail page

The mainteiner is shown under a Owners title.

captura de pantalla_2018-02-27_12-51-46

I think we should use the same word for this, either Mainteiners or Owners but not both.

@humitos humitos added the Improvement Minor improvement to code label Feb 27, 2018
@humitos humitos added this to the UI Improvements milestone Feb 27, 2018
@ajatprabha
Copy link
Contributor

Hi @humitos, I would like to implement this. Since I'm new here, can you please tell me the next step towards the process.

@stsewd
Copy link
Member

stsewd commented Feb 27, 2018

This was a question I had the other day, if rtd differences between the main owner (who created the project) and others owners.

@ajatprabha
Copy link
Contributor

Hey @stsewd, from what I've inspected in the Project model, RTD doesn't differentiate between owner and maintainers. A user(maintainer/owner) can remove another user.
If A is an owner and B is a maintainer, B can remove A, because of users attribute (ManyToMany relation with User model) and logic implemented.

@humitos, I believe that's why you've considered this a UI enhancement and not a model critical design change. Correct me if I missed something!
But I wanted to know if it is required to differentiate owner and maintainer?

@humitos
Copy link
Member Author

humitos commented Feb 28, 2018

Yes. I'm talking about the UI (not the behind the scenes and django modeling).

@ajatprabha
Copy link
Contributor

Should it be called owner or maintainer? In my opinion, maintainer is a better choice.

@ajatprabha
Copy link
Contributor

@humitos, since this issue is considered under UI improvement, I've created a PR with taking maintainer as the word because it is used in other places as well. Can you please review it?

@RichardLitt RichardLitt changed the title Adding a Mainteiner is shown as a Owner Adding a Maintainer is shown as a Owner Mar 2, 2018
@stsewd
Copy link
Member

stsewd commented Jun 14, 2018

This was resolved in #3703

@stsewd stsewd closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

3 participants