Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Our build system is broken #3691

Closed
agjohnson opened this issue Feb 27, 2018 · 6 comments
Closed

Our build system is broken #3691

agjohnson opened this issue Feb 27, 2018 · 6 comments
Labels
Bug A bug

Comments

@agjohnson
Copy link
Contributor

Because of the flight from Bower, several of our dependencies are no longer found in the bower repository. We need to either install these build dependencies from npm and hope that our build system can take these new pieces without much work, or just blow up everything and move on to webpack + npm ahead of schedule. I have a mostly working solution, I'll continue wrapping up this work for now.

Currently missing from bower:

  • jquery
  • jquery.payments
@DominikaK
Copy link

Is this the issue that broke the builds on readthedocs.com as well? Should that one be reported separately?

@willingc
Copy link
Contributor

@agjohnson Is this related or a different issue? There was a problem with Read the Docs while building your documentation. Please report this to us with your build id (6818352).

@humitos
Copy link
Member

humitos commented Feb 28, 2018

I don't think this bug is affecting the builds or the existing code but, it does affect the generation of the new code (minified js, etc).

@DominikaK I'd suggest you to contact the support email regarding .com

@willingc would you like to open a new issue with your problem by filling the template? Maybe I can help you.

@willingc
Copy link
Contributor

Thanks @humitos. I opened #3700. It may be related to some changes to bower-lite on our side. Though I'm not sure why.

@humitos
Copy link
Member

humitos commented Mar 23, 2018

@agjohnson this seems to be fixed now. I removed all my local files and I didn't have any problem with re-building them again.

~/rtfd/code/readthedocs.org on  master! ⌚ 12:38:01
$ rm -rf node_modules 
(3.6.4/envs/readthedocs.org) 
~/rtfd/code/readthedocs.org on  master! ⌚ 12:38:06
$ npm install
npm WARN deprecated [email protected]: 'github' has been renamed to '@octokit/rest' (https://git.io/vNB11)
npm WARN deprecated [email protected]: ...psst! Your project can stop working at any moment because its dependencies can change. Prevent this by migrating to Yarn: https://bower.io/blog/2017/how-to-migrate-away-from-bower/
npm WARN deprecated [email protected]: graceful-fs v3.0.0 and before will fail on node releases >= v7.0. Please update to graceful-fs@^4.0.0 as soon as possible. Use 'npm ls graceful-fs' to find it in the tree.
npm WARN deprecated [email protected]: Use uuid module instead
npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
npm WARN deprecated [email protected]: ReDoS vulnerability parsing Set-Cookie https://nodesecurity.io/advisories/130
npm WARN deprecated [email protected]: this package has been reintegrated into npm and is now out of date with respect to npm
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules/fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"})

added 987 packages from 799 contributors in 22.297s
(3.6.4/envs/readthedocs.org) 
~/rtfd/code/readthedocs.org on  master! ⌚ 12:38:35
$ ./node_modules/.bin/bower install
(3.6.4/envs/readthedocs.org) 
~/rtfd/code/readthedocs.org on  master! ⌚ 12:38:48
$ ./node_modules/.bin/gulp build   
[12:38:53] Using gulpfile ~/rtfd/code/readthedocs.org/gulpfile.js
[12:38:53] Starting 'build'...
[12:38:53] Building source files
(node:25884) [DEP0022] DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.
[12:38:54] Collecting static files
[12:38:56] Finished 'build' after 2.99 s
$ ./manage.py collectstatic --noinput
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/static/projects/js/tools.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/static/projects/js/import.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/static/projects/css/import.css'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/projects/static/projects/css/admin.css'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/builds/static/builds/js/detail.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/js/autocomplete.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/js/site.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/js/readthedocs-doc-embed.js'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/fontawesome-webfont.eot'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/fontawesome-webfont.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/Lato-Regular.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/RobotoSlab-Regular.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/FontAwesome.otf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/Lato-Bold.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/fontawesome-webfont.svg'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/fontawesome-webfont.woff'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/RobotoSlab-Bold.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/Inconsolata-Bold.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/font/Inconsolata-Regular.ttf'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/css/badge_only.css'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/core/static/core/css/theme.css'
Copying '/home/humitos/rtfd/code/readthedocs.org/readthedocs/gold/static/gold/js/gold.js'

22 static files copied to '/home/humitos/rtfd/code/readthedocs.org/media/static', 111 unmodified.
(3.6.4/envs/readthedocs.org) 
~/rtfd/code/readthedocs.org on  master! ⌚ 12:38:56
$ 

@ericholscher
Copy link
Member

Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

5 participants