Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the 'bookmarks' app completely #3659

Closed
humitos opened this issue Feb 23, 2018 · 2 comments
Closed

Remove the 'bookmarks' app completely #3659

humitos opened this issue Feb 23, 2018 · 2 comments
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Milestone
Cleanup

Comments

@humitos
Copy link
Member

humitos commented Feb 23, 2018

There is a django app bookmarks that can be completely removed since it's not used at all: https://github.com/rtfd/readthedocs.org/tree/e9d0d2ff5b70e1c0b58be512a6cf10e7c11930b3/readthedocs/bookmarks

Consider that removing this app could help us to not depend in django-pagination since it's used in some of the bookmarks templates.
@humitos humitos added the Improvement Minor improvement to code label Feb 23, 2018
@humitos humitos added this to the Cleanup milestone Feb 23, 2018
@humitos humitos mentioned this issue Feb 23, 2018
Closed
@humitos humitos added the Good First Issue Good for new contributors label Feb 23, 2018
@Jigar3 Jigar3 mentioned this issue Feb 23, 2018
Merged
@xrmx
Copy link
Contributor

xrmx commented May 4, 2018

@humitos looks like this can be closed

@stsewd
Copy link
Member

stsewd commented May 8, 2018

This was solved on #3663

@stsewd stsewd closed this as completed May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
3 participants
@xrmx @humitos @stsewd