Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to specify which version of Docker image to use #3338

Closed
dselman opened this issue Nov 30, 2017 · 6 comments
Closed

Add ability to specify which version of Docker image to use #3338

dselman opened this issue Nov 30, 2017 · 6 comments
Labels
Improvement Minor improvement to code

Comments

@dselman
Copy link

dselman commented Nov 30, 2017

Details

I have a project that requires the sphinx_jsdoc support which is available in the latest version of the Docker build images. However it would appear that readthedocs is currently using the 2.0 Docker build images.

Adding a YML or UI option to specify the version of the Docker build image to use would allow project to test experimental features, and for my project to use jsdoc.

Expected Result

  • Specify the latest tag in .readthedocs.yml
  • The latest Docker image is used
  • The build can use sphinx_js and jsdoc

Actual Result

Build fails because the sphinx_js extension requires jsdoc to be installed and on the path.

@dselman
Copy link
Author

dselman commented Nov 30, 2017

@humitos
Copy link
Member

humitos commented Nov 30, 2017

There is a form at http://docs.readthedocs.io/en/latest/yaml-config.html#python-version where you can request to use the latest image builder.

@ericholscher
Copy link
Member

My thoughts:

This leaves us open for creating more custom docker images in the future, if we find it useful!

@ericholscher
Copy link
Member

Will do a PR with this now.

@agjohnson
Copy link
Contributor

👍

Also s/docker_image/build_image/ to match our nomenclature.

@humitos humitos added the Improvement Minor improvement to code label Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants