Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search results for mkdocs do not use CNAME #1628

Closed
itayher opened this issue Sep 7, 2015 · 9 comments
Closed

Search results for mkdocs do not use CNAME #1628

itayher opened this issue Sep 7, 2015 · 9 comments
Labels
Bug A bug

Comments

@itayher
Copy link

itayher commented Sep 7, 2015

When ever I search for a phrase in the documentation, the results links are coming back with wrong URL. It seems that they don't consider multi level. Also the URL comes with readthedocs.org domain and not the our domain. Is this a bug or we missing configuration?

@itayher itayher changed the title Search results URL are wrong Search results URL is wrong Sep 7, 2015
@itayher itayher changed the title Search results URL is wrong Search results URL are wrong Sep 7, 2015
@gregmuellegger gregmuellegger added the Bug A bug label Sep 7, 2015
@gregmuellegger
Copy link
Contributor

Seems to work ok for the pip project: https://pip.pypa.io/en/stable/search.html?q=setuptools&check_keywords=yes&area=default
Can you provide us with a link to a malfunctioning search?

@gregmuellegger gregmuellegger added the Needed: more information A reply from issue author is required label Sep 7, 2015
@itayher
Copy link
Author

itayher commented Sep 7, 2015

Yes, I see it is working for you.
In http://docs.backand.com search for ORM, the result looks different (doesn't use the highlight cool feature) and if you click on the link to the page you see it is broken.
Thanks for the help

@gregmuellegger gregmuellegger changed the title Search results URL are wrong Search results for mkdocs do not use CNAME Sep 7, 2015
@gregmuellegger
Copy link
Contributor

Ok thanks for the example. I assume the reason is that there is no specific theme for a mkdocs based documentation. However it should ofcourse take the configured CNAME into account. We'll need to have a look there.

@gregmuellegger
Copy link
Contributor

I think we can't address this issue currently in a proper way as readthedocs.org does not know anything about configured CNAMEs. I created #1632 as a new issue in order to propose some way to configure the "main" domain that should be used to link to a project's documentation.

@itayher
Copy link
Author

itayher commented Sep 7, 2015

How can I setup the search to return results with highlighted text and not in the way it is now.
Regarding the CNAME, the URL is broken not just because of the domain name but also it doesn't include folder structure (try to replace the result domain with docs.backand.com and still remain broken).

@gregmuellegger
Copy link
Contributor

Thanks for pointing out the broken links! I missed that in the first look through. I've opened #1633 to track it separately.

Regarding the highlighting: the text is actually highlighted, but only by making it italic:
screen1
You can see the word ORM being in italic.

Actually while writing this, I realized that you mean the highlighting of the words when following the link from the search to the docs, right? For example, the following link should highlight the word "database", correct? http://backand-docs.readthedocs.org/en/latest/?highlight=database

@itayher
Copy link
Author

itayher commented Sep 8, 2015

Yes, database was supposed to be highlight

@gregmuellegger
Copy link
Contributor

That feature did not exist so far for mkdocs projects. I created #1640 to suggest an implementation of this.

@gregmuellegger
Copy link
Contributor

Seems like there have been three main points in this ticket that we did split out into:

I'm closing this ticket as we have the other three open to track the individual progress.

@itayher I hope this addresses all of your issues. Respond here if I have forgotten something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug
Projects
None yet
Development

No branches or pull requests

2 participants