From 7bf6ee72250b0c8ffc0b4a2dc94cd9e372b178a6 Mon Sep 17 00:00:00 2001
From: Manuel Kaufmann <humitos@gmail.com>
Date: Wed, 21 Dec 2022 12:03:30 +0100
Subject: [PATCH] Test: path is trimmed when returned by the API (#9824)

This commit contains the test that was missing for my other PR:
https://github.com/readthedocs/readthedocs.org/pull/9815

The test checks the commands' PATH are trimmed before being returned by the API.
---
 readthedocs/rtd_tests/tests/test_api.py | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/readthedocs/rtd_tests/tests/test_api.py b/readthedocs/rtd_tests/tests/test_api.py
index 8ee068b7d5e..f00bd731d01 100644
--- a/readthedocs/rtd_tests/tests/test_api.py
+++ b/readthedocs/rtd_tests/tests/test_api.py
@@ -6,7 +6,7 @@
 from allauth.socialaccount.models import SocialAccount
 from django.contrib.auth.models import User
 from django.http import QueryDict
-from django.test import TestCase
+from django.test import TestCase, override_settings
 from django.urls import reverse
 from django_dynamic_fixture import get
 from rest_framework import status
@@ -303,17 +303,20 @@ def test_response_building(self):
         self.assertEqual(build['success'], True)
         self.assertEqual(build['docs_url'], dashboard_url)
 
+    @override_settings(DOCROOT="/home/docs/checkouts/readthedocs.org/user_builds")
     def test_response_finished_and_success(self):
         """The ``view docs`` attr should return a link to the docs."""
         client = APIClient()
         client.login(username='super', password='test')
         project = get(
             Project,
-            language='en',
+            language="en",
+            slug="myproject",
             main_language_project=None,
         )
         version = get(
             Version,
+            slug="myversion",
             project=project,
             built=True,
             uploaded=True,
@@ -325,6 +328,12 @@ def test_response_finished_and_success(self):
             state='finished',
             exit_code=0,
         )
+        buildcommandresult = get(
+            BuildCommandResult,
+            build=build,
+            command="/home/docs/checkouts/readthedocs.org/user_builds/myproject/envs/myversion/bin/python -m pip install --upgrade --no-cache-dir pip setuptools<58.3.0",
+            exit_code=0,
+        )
         resp = client.get('/api/v2/build/{build}/'.format(build=build.pk))
         self.assertEqual(resp.status_code, 200)
         build = resp.data
@@ -337,6 +346,11 @@ def test_response_finished_and_success(self):
         self.assertEqual(build['exit_code'], 0)
         self.assertEqual(build['success'], True)
         self.assertEqual(build['docs_url'], docs_url)
+        # Verify the path is trimmed
+        self.assertEqual(
+            build["commands"][0]["command"],
+            "python -m pip install --upgrade --no-cache-dir pip setuptools<58.3.0",
+        )
 
     def test_response_finished_and_fail(self):
         """The ``view docs`` attr should return a link to the dashboard."""