Inline styles

[stsewd]

I'm in the process of adding a strict content security policy. I'm going to use this issue to list inline styles, maybe other inlines I find.

ext-theme/readthedocsext/theme/templates/includes/header.html

Line 48 in b12ae41

<i class="fad fa-bars large icon" style="--fa-secondary-opacity: 0.8;"></i>

Actually, there are a couple of inline styles, just grepping for style= over html files returns lots of results, is that on purpose or just templates that we still need to migrate?

rg 'style=' **/*.html

[agjohnson]

Ah yes, good catch, I didn't think about removing these as part of the CSP work.

We probably have a couple versions of this inline style:

• display: none for when a KO element needs to start off hidden. I've since been using the CSS classes ko hidden instead, but this does take flipping some of the observable logic.
• There are a few icons tuned for display with FA rules. These could be custom CSS classes instead, or maybe FA has a newer approach. In some cases, we might just override .fad.fa-bars with the --fa-secondary-opacity var/rule.

[agjohnson]

Bumping this up to this current milestone so we can make the CSP stricter.