Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: ability to disable "keep the page when switching version/language" #267

Open
humitos opened this issue Mar 5, 2024 · 1 comment
Labels
Feature New feature Needed: design decision A core team decision is required

Comments

@humitos
Copy link
Member

humitos commented Mar 5, 2024

We added the feature to keep the page when switching version/language from the flyout. This feature was requested in #211 and it was also how the old flyout used to worked.

However, there may be cases where the project owner may not want this behavior and want to disable it. I think we could add a setting in the WebUI to disable this behavior in case it's wanted.

I found myself wanting this for test-builds project since all the "versions" of this project are unrelated between them and even each "version" may use a complete different doctool (e.g. Sphinx, Docusaurus or Pelican). Opening a post on the Pelican version will make all the links from the flyout to be invalid since none of those files exist on any of the other versions.

I know this may be an edge case, because of the way how we use the test-builds project. However, I wanted to open an issue here to expose this to other users and receive feedback to decide whether or not implement the ability to disable it.

@humitos humitos added Feature New feature Needed: design decision A core team decision is required labels Mar 5, 2024
@humitos
Copy link
Member Author

humitos commented Oct 10, 2024

We've implemented the same feature for notifications in #390, so we may want to consider this config there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New feature Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

1 participant