Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain page when switching version #223

Closed
astrojuanlu opened this issue Dec 19, 2023 · 1 comment
Closed

Retain page when switching version #223

astrojuanlu opened this issue Dec 19, 2023 · 1 comment

Comments

@astrojuanlu
Copy link

Without add-ons, when the reader switches the version in the flyout, they land in the same page. For example:

  1. Open https://docs.poliastro.space/en/stable/quickstart.html
  2. Click "0.17.x" in the flyout
  3. Land in https://docs.poliastro.space/en/0.17.x/quickstart.html ✔️

Now, with add-ons, when the reader switches the version in the flyout, they land in the home page. For example:

  1. Open https://docs.kedro.org/en/stable/introduction/index.html
  2. Click "0.19.0" in the flyout
  3. Land in https://docs.kedro.org/en/0.19.0/

The current behavior prevents arriving to a 404 page in cases where the current page doesn't exist in the other version (readthedocs/readthedocs.org#10643) but makes it more difficult to see differences between versions, and requires extra clicks to arrive where you were.

Is this intentional?

@humitos
Copy link
Member

humitos commented Dec 19, 2023

Is this intentional?

It is intentional... for now, at least 😄

The same issue was reported at #211 (please, subscribe there) and I have some doubts about how to implement this in a way that gives a good UX to users. I need to think more about how to do it properly.

I'm closing this issue as duplicate of #211.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants