Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout: keep version on lang switch #130

Closed
trasher opened this issue Jun 18, 2020 · 3 comments · Fixed by #242
Closed

Flyout: keep version on lang switch #130

trasher opened this issue Jun 18, 2020 · 3 comments · Fixed by #242
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@trasher
Copy link

trasher commented Jun 18, 2020

Details

Currently, the above page exists only in the develop version of the documentation.
When switching to another language; current version should be kept but is not (just try to switch to another language).

Expected Result

User is redirected to the current page on current version with selected lang.

Actual Result

User is redirected to the current page on latest version with selected lang (page that does not exists).

@trasher trasher changed the title Keep branch on lang switch Keep version on lang switch Jun 18, 2020
@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Jun 18, 2020
@humitos
Copy link
Member

humitos commented Sep 15, 2023

I think this is already solved in the new flyout addons we are working on, but we should double check it. I'm moving the issue over there.

@humitos humitos transferred this issue from readthedocs/readthedocs.org Sep 15, 2023
@humitos humitos changed the title Keep version on lang switch Flyout: keep version on lang switch Sep 15, 2023
@humitos humitos closed this as completed in d1ba63c Mar 5, 2024
@humitos
Copy link
Member

humitos commented Mar 5, 2024

This change is deployed. Now, switching between versions/languages from the flyout addons will keep the page the user is looking at on the version/language destination.

@trasher
Copy link
Author

trasher commented Mar 5, 2024

Thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants