From 5f675fbda7c05a94857f50bc01751432b853fa31 Mon Sep 17 00:00:00 2001 From: Kanad Gupta Date: Thu, 10 Mar 2022 09:22:04 -0600 Subject: [PATCH 1/6] chore(GHA): drop setup-node step --- action.yml | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/action.yml b/action.yml index decd2d256..a9f9342c0 100644 --- a/action.yml +++ b/action.yml @@ -12,13 +12,21 @@ runs: using: composite steps: # This is so we can guarantee a version of npm that supports lockfile@2 - - name: setup node - uses: actions/setup-node@v3 - with: - node-version: 16 + # - name: setup node + # uses: actions/setup-node@v3 + # with: + # node-version: 16 + - name: Node version + run: node -v + shell: bash + working-directory: ${{ github.action_path }} + - name: npm version + run: npm -v + shell: bash + working-directory: ${{ github.action_path }} # When we add debug support, we should make this a conditional step, see RM-3545 - name: Install rdme deps - run: npm install --production --silent + run: npm install --production > /dev/null shell: bash working-directory: ${{ github.action_path }} - name: Execute rdme command From 1c9862e5063d1d69a9c64f17f9f2f432e0547429 Mon Sep 17 00:00:00 2001 From: Kanad Gupta Date: Thu, 10 Mar 2022 10:06:41 -0600 Subject: [PATCH 2/6] docs: update contributing guidelines Turns out my `ghcr.io/catthehacker/ubuntu` image was out-of-date, so I was using a different version of Node locally than what was actually running on GitHub :facepalm: This updates our contributing guidelines to call this out (mostly for myself) --- CONTRIBUTING.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 075875e8f..372b1a12a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,6 +33,8 @@ Once you've installed `act`, it'll ask you what Docker image size you'd like. Th -P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04 ``` +> Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently—you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic [pull](https://docs.docker.com/desktop/dashboard/#pull-the-latest-image-from-docker-hub). + Once it's configured, you can use the `-l` flag to to view all the workflows: ```sh From 21a780a3f40f4644483802183933e9482b46ee70 Mon Sep 17 00:00:00 2001 From: Kanad Gupta Date: Thu, 10 Mar 2022 10:07:52 -0600 Subject: [PATCH 3/6] revert(kinda): remove all debugging, drop setup-node step --- action.yml | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/action.yml b/action.yml index a9f9342c0..dc7f23e74 100644 --- a/action.yml +++ b/action.yml @@ -11,22 +11,9 @@ inputs: runs: using: composite steps: - # This is so we can guarantee a version of npm that supports lockfile@2 - # - name: setup node - # uses: actions/setup-node@v3 - # with: - # node-version: 16 - - name: Node version - run: node -v - shell: bash - working-directory: ${{ github.action_path }} - - name: npm version - run: npm -v - shell: bash - working-directory: ${{ github.action_path }} # When we add debug support, we should make this a conditional step, see RM-3545 - name: Install rdme deps - run: npm install --production > /dev/null + run: npm install --production --silent shell: bash working-directory: ${{ github.action_path }} - name: Execute rdme command From 0496788f63c1cdb37d4befebff961600fe82521f Mon Sep 17 00:00:00 2001 From: Kanad Gupta Date: Thu, 10 Mar 2022 10:12:28 -0600 Subject: [PATCH 4/6] chore: remove comment --- action.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/action.yml b/action.yml index dc7f23e74..6064ed047 100644 --- a/action.yml +++ b/action.yml @@ -11,7 +11,6 @@ inputs: runs: using: composite steps: - # When we add debug support, we should make this a conditional step, see RM-3545 - name: Install rdme deps run: npm install --production --silent shell: bash From a48aec777ac888a52dc16802e067a985045dedee Mon Sep 17 00:00:00 2001 From: Kanad Gupta Date: Thu, 10 Mar 2022 10:30:45 -0600 Subject: [PATCH 5/6] docs: use CLI command instead --- CONTRIBUTING.md | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 372b1a12a..25259a41f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,7 +33,11 @@ Once you've installed `act`, it'll ask you what Docker image size you'd like. Th -P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04 ``` -> Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently—you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic [pull](https://docs.docker.com/desktop/dashboard/#pull-the-latest-image-from-docker-hub). +Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently—you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic pull: + +```sh +docker pull ghcr.io/catthehacker/ubuntu:act-latest +``` Once it's configured, you can use the `-l` flag to to view all the workflows: From 6e1f59b8fd435ca5582bd20a96409105d6d9b956 Mon Sep 17 00:00:00 2001 From: Jon Ursenbach Date: Thu, 10 Mar 2022 09:25:23 -0800 Subject: [PATCH 6/6] Update CONTRIBUTING.md Co-authored-by: Alex Tymchuk --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 25259a41f..ac6297b8c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -33,7 +33,7 @@ Once you've installed `act`, it'll ask you what Docker image size you'd like. Th -P ubuntu-18.04=ghcr.io/catthehacker/ubuntu:act-18.04 ``` -Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently—you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic pull: +Our GitHub Actions guidance states that Action workflows should have a [`runs-on` value](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idruns-on) of `ubuntu-latest`. These runners are updated frequently — you can find links to the the latest versions by navigating [here](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#preinstalled-software) and selecting the latest Ubuntu link. Because of this, you'll want to make sure your `ghcr.io/catthehacker/ubuntu` image stays up-to-date by doing a periodic pull: ```sh docker pull ghcr.io/catthehacker/ubuntu:act-latest