fix(fetch): stricter source URL type-checking #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
bug
erunion
approved these changes
Jun 5, 2023
kanadgupta
pushed a commit
that referenced
this pull request
Jun 5, 2023
## [8.6.4-next.3](v8.6.4-next.2...v8.6.4-next.3) (2023-06-05) ### Bug Fixes * **fetch:** stricter source URL type-checking ([#818](#818)) ([d082473](d082473)) [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
This reworks the fix I had in #817 to utilize the
URLconstructor to construct the URL that we pass in thex-readme-source-urlheader. That way we can properly encode weird characters like in #817, in addition to also ensuring that the string itself is a valid URL.🧬 QA & Testing
Check out the new test case I added.