ci: fix code coverage in github actions #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Feb 1, 2023
| @@ -10,9 +11,8 @@ module.exports = { | |||
| statements: 90, | |||
| }, | |||
| }, | |||
| modulePaths: ['<rootDir>'], | |||
There was a problem hiding this comment.
I didn't need to make this and the roots change to get coverage working, we just don't need to set those configs here. rootDir is good enough.
kanadgupta
reviewed
Feb 1, 2023
jest.config.js
Outdated
| coveragePathIgnorePatterns: ['/dist', '/node_modules'], | ||
| coverageDirectory: 'coverage', | ||
| coveragePathIgnorePatterns: ['<rootDir>/dist', '<rootDir>/node_modules'], | ||
| coverageReporters: ['text-summary'], |
There was a problem hiding this comment.
Is this line required for it to work again or could we bring back the table view?
There was a problem hiding this comment.
Changed this to text and it brought back the table view.
You're just going to lose the lcov reporter that generates the fancy HTML page but I don't know if you ever used that locally or not. https://istanbul.js.org/docs/advanced/alternative-reporters/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Code coverage in Github Actions is broken due to Jest, for whatever reason, not automatically creating code coverage directories. I was able to partialy fix this by first creating a
coverage/directory but even after chmod'ing with 777 permissions it still wouldn't createcoverage/lconv-report/.As
coverage/lconv-reporthas a whole bunch of subdirectories that I have no desire to try to keep up with in a CI workflow, I've just changed our Jest code coverage to use a simpler reporter that dumps to the console.