Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: page deletion order in docs:prune #737

Merged
merged 3 commits into from
Jan 31, 2023
Merged

fix: page deletion order in docs:prune #737

merged 3 commits into from
Jan 31, 2023

Conversation

kanadgupta
Copy link
Member

🧰 Changes

Noticed two tiny issues in the docs:prune command that are fixed in this PR:

  • Noticed that folks would see this error if attempting to delete a page that contained children, so I just added a little array sorting into the mix so pages with children are deleted after pages without children.

CleanShot 2023-01-30 at 18 25 36@2x

  • Added an extra space between the 🗑️ bin and the confirmation message because yikes:

CleanShot 2023-01-30 at 18 24 42@2x

🧬 QA & Testing

Do tests pass?

@kanadgupta kanadgupta added bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands labels Jan 31, 2023
@kanadgupta kanadgupta marked this pull request as ready for review January 31, 2023 02:56
erunion
erunion approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me

@kanadgupta kanadgupta merged commit 848c63b into main Jan 31, 2023
@kanadgupta kanadgupta deleted the prune-fixes branch January 31, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erunion erunion erunion approved these changes

@Dashron Dashron Awaiting requested review from Dashron

@darrenyong darrenyong Awaiting requested review from darrenyong

Assignees
No one assigned
Labels
bug Something isn't working command:docs Issues pertaining to the `docs`, `changelogs`, or `custompages` commands
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanadgupta @erunion