Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use var instead of secret #733

Merged
merged 1 commit into from
Jan 25, 2023
Merged

ci: use var instead of secret #733

merged 1 commit into from
Jan 25, 2023

Conversation

kanadgupta
Copy link
Member

@kanadgupta kanadgupta commented Jan 25, 2023

🧰 Changes

GitHub Actions now supports variables, so swapping out the version secret for a version variable.

Further reading: https://github.blog/changelog/2023-01-10-github-actions-support-for-configuration-variables-in-workflows/

🧬 QA & Testing

In the docs syncing dry run step, note how the version is no longer masked:

CleanShot 2023-01-25 at 11 48 03@2x

Here's what it looks like for the same workflow in main:

CleanShot 2023-01-25 at 11 48 56@2x

@kanadgupta kanadgupta marked this pull request as ready for review January 25, 2023 17:45
@kanadgupta kanadgupta added the enhancement New feature or request label Jan 25, 2023
@kanadgupta kanadgupta requested a review from erunion January 25, 2023 17:48
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@kanadgupta kanadgupta merged commit 579aaa0 into main Jan 25, 2023
@kanadgupta kanadgupta deleted the try-var-instead-of-secret branch January 25, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants