feat: ability to pass in API key via env vars #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's unlikely that the user won't have a key and that the env will mess with this, so let's just use this logic to keep everything tidy
RyanGWU82
suggested changes
Dec 9, 2022
erunion
approved these changes
Dec 9, 2022
feedback: #709 (comment)
feedback: #709 (comment)
erunion
approved these changes
Dec 9, 2022
RyanGWU82
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
Allows a user to pass in an API key via an env variable called
RDME_API_KEY(as part of some little upcoming projects 👀). Also added some tests and docs related to this.I tried to abstract away all the complexity around this by creating a new
getStoredConfig()function, lemme know what y'all think!