chore(deps-dev): bumping dev deps and resolving type -> interface conversions #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
commented
Dec 8, 2022
| @@ -10,14 +10,16 @@ import fetch, { cleanHeaders, handleRes } from '../../lib/fetch'; | |||
| import * as promptHandler from '../../lib/prompts'; | |||
| import promptTerminal from '../../lib/promptWrapper'; | |||
|
|
|||
| export type VersionCreateOptions = { fork?: string } & VersionBaseOptions; | |||
| export interface Options extends CommonOptions { | |||
There was a problem hiding this comment.
Renamed this and VersionBaseOptions so they're consistent with our other commands.
kanadgupta
approved these changes
Dec 9, 2022
| @@ -45,8 +45,6 @@ export default async function promptTerminal<T extends string = string>( | |||
| // eslint-disable-next-line no-param-reassign | |||
| questions = questions.map(question => ({ onRender, ...question })); | |||
| } else { | |||
| // @ts-expect-error onRender is not a documented type, | |||
| // but it definitely is a thing: https://github.com/terkelg/prompts#onrender | |||
There was a problem hiding this comment.
holy shit they finally fixed this? 😭
There was a problem hiding this comment.
yeah i bumped @types/prompts and the expect-error started throwing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.