feat(open): rdme open should have a flag for opening the dash
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
requested changes
Nov 17, 2022
kanadgupta
added
command:other
kanadgupta
approved these changes
Nov 17, 2022
erunion
reviewed
Nov 17, 2022
| return expect(cmd.run({ mockOpen, dash: true, key: '12345' })).resolves.toBe( | ||
| `Opening ${chalk.green(dashUrl)} in your browser...` | ||
| ); | ||
| mockRequest.done(); |
There was a problem hiding this comment.
@kanadgupta @darrenyong This line doesn't get called because it's after a return. This might end up leading to some test memory leaks with mocks not getting cleaned up.
There was a problem hiding this comment.
oops, great catch, thanks! will fix
There was a problem hiding this comment.
wish we had a lint rule for stuff like this
There was a problem hiding this comment.
Yeah I'm surprised that ESLint didn't pick up on it.
There was a problem hiding this comment.
oops, thanks Jon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We're adding a
--dashoption tordme openso that it'll open the project dashboard in the browser.🧬 QA & Testing